From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751190AbdA0Trh (ORCPT ); Fri, 27 Jan 2017 14:47:37 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34389 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbdA0TrG (ORCPT ); Fri, 27 Jan 2017 14:47:06 -0500 Date: Fri, 27 Jan 2017 20:40:12 +0100 From: Pavel Machek To: Kalle Valo Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Arend Van Spriel , Ming Lei , "Luis R. Rodriguez" , Greg Kroah-Hartman , David Gnedt , Michal Kazior , Daniel Wagner , Tony Lindgren , Sebastian Reichel , Ivaylo Dimitrov , Aaro Koskinen , Grazvydas Ignotas , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data Message-ID: <20170127194012.GE20571@amd> References: <20170127094342.GC24223@pali> <20170127101043.GD24223@pali> <20170127103408.GG24223@pali> <87bmus7mfk.fsf@kamboji.qca.qualcomm.com> <20170127115706.GH24223@pali> <8737g47kpd.fsf@kamboji.qca.qualcomm.com> <20170127131146.GI24223@pali> <87bmus5xyc.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wTWi5aaYRw9ix9vO" Content-Disposition: inline In-Reply-To: <87bmus5xyc.fsf@kamboji.qca.qualcomm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wTWi5aaYRw9ix9vO Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > Pali Roh=E1r writes: >=20 > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > >> Pali Roh=E1r writes: > >>=20 > >> > 2) It was already tested that example NVS data can be used for N900 = e.g. > >> > for SSH connection. If real correct data are not available it is bet= ter > >> > to use at least those example (and probably log warning message) so = user > >> > can connect via SSH and start investigating where is problem. > >>=20 > >> I disagree. Allowing default calibration data to be used can be > >> unnoticed by user and left her wondering why wifi works so badly. > > > > So there are only two options: > > > > 1) Disallow it and so these users will have non-working wifi. > > > > 2) Allow those data to be used as fallback mechanism. > > > > And personally I'm against 1) because it will break wifi support for > > *all* Nokia N900 devices right now. >=20 > All two of them? :) Umm. You clearly want a flock of angry penguins at your doorsteps :-). > But not working is exactly my point, if correct calibration data is not > available wifi should not work. And it's not only about functionality > problems, there's also the regulatory aspect. If you break existing configuration that's called "regression". > >> > 3) If we do rename *now* we will totally break wifi support on Nokia > >> > N900. > >>=20 > >> Then the distro should fix that when updating the linux-firmware > >> packages. Can you provide details about the setup, what distro etc? > > > > Debian stable, Ubuntu LTSs 14.04, 16.04.=20 >=20 > You can run these out of box on N900? Debian stable does. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --wTWi5aaYRw9ix9vO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAliLohwACgkQMOfwapXb+vIMowCfafqFiiWLUvCz/ObElhmeZ2MC OP0An0zg74gU6k3v3GVikgkzmVssYyUa =Pi8Z -----END PGP SIGNATURE----- --wTWi5aaYRw9ix9vO--