From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751906AbdA1OSb (ORCPT <rfc822;w@1wt.eu>);
        Sat, 28 Jan 2017 09:18:31 -0500
Received: from bhuna.collabora.co.uk ([46.235.227.227]:34932 "EHLO
        bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751339AbdA1OSX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 28 Jan 2017 09:18:23 -0500
Date: Sat, 28 Jan 2017 15:16:46 +0100
From: Peter Senna Tschudin <peter.senna@collabora.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: airlied@linux.ie, akpm@linux-foundation.org, daniel.vetter@ffwll.ch,
        davem@davemloft.net, devicetree@vger.kernel.org,
        dri-devel@lists.freedesktop.org, enric.balletbo@collabora.com,
        eballetbo@gmail.com, galak@codeaurora.org, gregkh@linuxfoundation.org,
        heiko@sntech.de, ijc+devicetree@hellion.org.uk, javier@dowhile0.org,
        jslaby@suse.cz, kernel@pengutronix.de,
        linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
        linux-kernel@vger.kernel.org, linux@roeck-us.net, mark.rutland@arm.com,
        martin.donnelly@ge.com, martyn.welch@collabora.co.uk,
        mchehab@osg.samsung.com, pawel.moll@arm.com, peter.senna@gmail.com,
        p.zabel@pengutronix.de, thierry.reding@gmail.com,
        rmk+kernel@armlinux.org.uk, robh+dt@kernel.org, shawnguo@kernel.org,
        tiwai@suse.com, treding@nvidia.com, ykk@rock-chips.com,
        Rob Herring <robh@kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++
 Bridge
Message-ID: <20170128141646.GA21291@collabora.com>
References: <cover.1483301745.git.peter.senna@collabora.com>
 <4232c88a99f44a24287d04d74b891e2eb139864c.1483301745.git.peter.senna@collabora.com>
 <759f96e2-43da-45ba-cf8d-55bc1f6e8442@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <759f96e2-43da-45ba-cf8d-55bc1f6e8442@codeaurora.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote:
Hi Archit,

Thank you for the comments!

[...]
> > +	total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH;
> > +	if (total_size > EDID_LENGTH) {
> > +		kfree(block);
> > +		block = kmalloc(total_size, GFP_KERNEL);
> > +		if (!block)
> > +			return NULL;
> > +
> > +		/* Yes, read the entire buffer, and do not skip the first
> > +		 * EDID_LENGTH bytes.
> > +		 */
> 
> Is this the reason why you aren't using drm_do_get_edid()?

Yes, for some hw specific reason, it is necessary to read the entire
EDID buffer starting from 0, not block by block.

[...]

I fixed all your other suggestions. Thank you!