From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751380AbdA2XYb (ORCPT ); Sun, 29 Jan 2017 18:24:31 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:40750 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbdA2XYX (ORCPT ); Sun, 29 Jan 2017 18:24:23 -0500 Date: Sun, 29 Jan 2017 18:24:21 -0500 (EST) Message-Id: <20170129.182421.2254139449919836161.davem@davemloft.net> To: colin.king@canonical.com Cc: Pavel.Belous@aquantia.com, Alexander.Loktionov@aquantia.com, Dmitry.Bezrukov@aquantia.com, vomlehn@texas.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][net-next] net: ethernet: aquantia: remove another redundant err check From: David Miller In-Reply-To: <20170127150025.18886-1-colin.king@canonical.com> References: <20170127150025.18886-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 29 Jan 2017 14:25:20 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Fri, 27 Jan 2017 15:00:25 +0000 > From: Colin Ian King > > The check on err < 0 is redundant and can be removed. Detected > by CoverityScan, CID#1398318 ("Logically Dead Code") > > Signed-off-by: Colin Ian King Applied.