From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbdA3Gnb (ORCPT ); Mon, 30 Jan 2017 01:43:31 -0500 Received: from verein.lst.de ([213.95.11.211]:47500 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbdA3GnW (ORCPT ); Mon, 30 Jan 2017 01:43:22 -0500 Date: Mon, 30 Jan 2017 07:34:57 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: linux-next: build failure after merge of the block tree Message-ID: <20170130063457.GA2592@lst.de> References: <20170130124350.36a57549@canb.auug.org.au> <5f2da80f-c6fe-8c45-0e56-819aae7d925c@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f2da80f-c6fe-8c45-0e56-819aae7d925c@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 29, 2017 at 06:53:42PM -0700, Jens Axboe wrote: > Huh, I wonder how that snuck past my allmodconfig builds, that looks > like a clear failure. I also did tons of test builds and never saw it, not sure why the NVMe-SCSI code still someone how an implicit include of scsi_cmnd.h. But in the end it should not be using the defintion anyway, and I sent a patch on Saturday so that it doesn't: [PATCH 1/5] nvme/scsi: don't rely on BLK_MAX_CDB might make sense to expedite that.