From: Thierry Reding <thierry.reding@gmail.com>
To: Shailendra Verma <shailendra.v@samsung.com>
Cc: David Airlie <airlied@linux.ie>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, p.shailesh@samsung.com,
ashish.kalra@samsung.com,
Shailendra Verma <shailendra.capricorn@gmail.com>
Subject: Re: [PATCH] Gpu: drm: tegra - Fix possible NULL derefrence.
Date: Mon, 30 Jan 2017 08:11:12 +0100 [thread overview]
Message-ID: <20170130071112.GF3585@ulmo.ba.sec> (raw)
In-Reply-To: <1485752025-29465-1-git-send-email-shailendra.v@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
On Mon, Jan 30, 2017 at 10:23:45AM +0530, Shailendra Verma wrote:
> of_match_device could return NULL, and so can cause a NULL
> pointer dereference later.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
> drivers/gpu/drm/tegra/sor.c | 4 ++++
> 1 file changed, 4 insertions(+)
No, this will never happen on Tegra. If you reach the ->probe() function
this pointer is guaranteed to be non-NULL.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-01-30 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170130045353epcas2p198210c8758d8a9d35fbfcfd8d24cc072@epcas2p1.samsung.com>
2017-01-30 4:53 ` [PATCH] Gpu: drm: tegra - Fix possible NULL derefrence Shailendra Verma
2017-01-30 7:11 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130071112.GF3585@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=airlied@linux.ie \
--cc=ashish.kalra@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.shailesh@samsung.com \
--cc=shailendra.capricorn@gmail.com \
--cc=shailendra.v@samsung.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).