From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbdA3JMT (ORCPT ); Mon, 30 Jan 2017 04:12:19 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43398 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbdA3JLz (ORCPT ); Mon, 30 Jan 2017 04:11:55 -0500 Date: Mon, 30 Jan 2017 10:03:07 +0100 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , Linus Walleij , Vinod Koul , Mark Brown , Jaroslav Kysela , Andre Przywara , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, dmaengine@vger.kernel.org, alsa-devel@alsa-project.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5 Message-ID: <20170130090307.mmeab5ybfxaeicq2@lukather> References: <20170129023331.62106-1-icenowy@aosc.xyz> <20170129023331.62106-4-icenowy@aosc.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oa6hxwnkli4wexjx" Content-Disposition: inline In-Reply-To: <20170129023331.62106-4-icenowy@aosc.xyz> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --oa6hxwnkli4wexjx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Jan 29, 2017 at 10:33:24AM +0800, Icenowy Zheng wrote: > As the CCU in the Allwinner H5 SoC is very similar to the one in H3, > rename the H3 driver to sunxi-h3-h5 so that it can be extended with H5 > support. >=20 > Signed-off-by: Icenowy Zheng > --- > The original PATCH v2 3/9 is splited into two patches in v3, this one ren= ames > the H3 driver to h3-h5, and the next one finally add H5 support to it. >=20 > drivers/clk/sunxi-ng/Kconfig | 4 +- > drivers/clk/sunxi-ng/Makefile | 2 +- > .../sunxi-ng/{ccu-sun8i-h3.c =3D> ccu-sunxi-h3-h5.c} | 42 +++--- > .../sunxi-ng/{ccu-sun8i-h3.h =3D> ccu-sunxi-h3-h5.h} | 10 +- > include/dt-bindings/clock/sun8i-h3-ccu.h | 146 +--------------= ------ > include/dt-bindings/clock/sunxi-h3-h5-ccu.h | 145 +++++++++++++++= +++++ > include/dt-bindings/reset/sun8i-h3-ccu.h | 104 +-------------- > include/dt-bindings/reset/sunxi-h3-h5-ccu.h | 103 +++++++++++++++ > 8 files changed, 282 insertions(+), 274 deletions(-) > rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.c =3D> ccu-sunxi-h3-h5.c} (96%) > rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.h =3D> ccu-sunxi-h3-h5.h} (88%) > mode change 100644 =3D> 120000 include/dt-bindings/clock/sun8i-h3-ccu.h > create mode 100644 include/dt-bindings/clock/sunxi-h3-h5-ccu.h > mode change 100644 =3D> 120000 include/dt-bindings/reset/sun8i-h3-ccu.h > create mode 100644 include/dt-bindings/reset/sunxi-h3-h5-ccu.h Please generate your patches with -M > -static void __init sun8i_h3_ccu_setup(struct device_node *node) > +static void __init sunxi_h3_h5_ccu_init(struct device_node *node, > + const struct sunxi_ccu_desc *desc) > { The indentation should be on the opening parenthesis. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --oa6hxwnkli4wexjx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYjwFHAAoJEBx+YmzsjxAgPTcQAL/ZIIw/DeJ4jCKzz+XTeBnQ ESz+LSRDEd23iLRIQBeGwYIQmBtdsobGoI7BkjKr57cwQoj+3kIz37g+fJSi2+xd kIOd+4y+H0IbEDtH/R1oFRNYP72ydxhyreXfLwG/affCncuXHKPBrv28nRFQzJ6i rEXB87cEeQ39SqziydU5N9uiWKjjBybEvyaBj4Pekh88XAoH2XGkyLc/A3kUROBZ eLOO2k3Vd4q9tNjbN8CTO07eqBFBz68nlHyfoU2OZ7bHZMhd8oUcxTAyelbj2EVM +mf4dRH4tDMfaXTTfQLfgmBkWMop1MRoy2w2TJOXTo86CnXdTa/AOC4KJvW+1XcV imV+8kw0lPKg9L/e7yOOI3rCKQJ3f4EO74RmDicbssB+8U8Aq10hE0BTtEtw1q61 0lS4GVB1BK82KiNBxnLqnpg6eELgM6pHHG639pKYLRFtaU5PkxRryJ0NduGXqqY7 nFwGiN6gvgFv9IYZAQz4C9xmLYkqglN8RGUB8eGCrUOuna+K4/kwQ4GTk2IzYiae WRKslZ7uixog/tShlUKbo2/EdiYJGXA38xctyl85dh6IeyuX+JxkrSZ4AEoCXyy2 RicjAytDoufQ0aLptPdDQAMkWCRXBJha4hBcIQEAFkcOApFMiy22O1OYhAjyK7kZ kJGSc35Ymxk/hR2O76FQ =77Ut -----END PGP SIGNATURE----- --oa6hxwnkli4wexjx--