From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "André Przywara" <andre.przywara@arm.com>
Cc: Icenowy Zheng <icenowy@aosc.xyz>, Chen-Yu Tsai <wens@csie.org>,
Linus Walleij <linus.walleij@linaro.org>,
Vinod Koul <vinod.koul@intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
dmaengine@vger.kernel.org, alsa-devel@alsa-project.org,
linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <Mark.Rutland@arm.com>
Subject: Re: [PATCH v3 05/10] arm: dts: sun8i: split Allwinner H3 .dtsi
Date: Mon, 30 Jan 2017 10:09:10 +0100 [thread overview]
Message-ID: <20170130090910.cer2nvedq3tjleih@lukather> (raw)
In-Reply-To: <2b8672bc-58ae-66a9-46d7-c7f3c5825a9d@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
On Mon, Jan 30, 2017 at 01:42:40AM +0000, André Przywara wrote:
> > +&ccu {
> > + compatible = "allwinner,sun8i-h3-ccu";
> > +};
>
> I believe this kind of sharing nodes is a bit frowned upon in connection
> with sharing .dtsi's. If the compatible name differs, I think it
> deserves to be a separate node spelt out in each SoC's .dtsi.
> This also makes the DT more readable, since a reader doesn't have to
> refer to two files to see what's in that node.
>
> >
> > - codec_analog: codec-analog@01f015c0 {
> > - compatible = "allwinner,sun8i-h3-codec-analog";
> > - reg = <0x01f015c0 0x4>;
> > - };
> > +&mmc0 {
> > + compatible = "allwinner,sun7i-a20-mmc";
> > + clocks = <&ccu CLK_BUS_MMC0>,
> > + <&ccu CLK_MMC0>,
> > + <&ccu CLK_MMC0_OUTPUT>,
> > + <&ccu CLK_MMC0_SAMPLE>;
> > + clock-names = "ahb",
> > + "mmc",
> > + "output",
> > + "sample";
>
> This applies even more here, since the MMC controllers also have
> different clock requirements.
>
> So why can't we just leave the CCU, MMC and possibly the pinctrl nodes
> completely out of the shared h3-h5.dtsi and introduce them from scratch
> in the SoC specific .dtsi?
>
> I think we still have enough identical nodes to justify this kind of
> .dtsi sharing.
We did it that way in the past in order to reduce the unneeded
duplication, but I can definitely understand your point. We'll wait
for the DT maintainers answer on this one.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-01-30 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170129023331.62106-1-icenowy@aosc.xyz>
[not found] ` <20170129023331.62106-4-icenowy@aosc.xyz>
2017-01-30 9:03 ` [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5 Maxime Ripard
[not found] ` <20170129023331.62106-5-icenowy@aosc.xyz>
2017-01-30 9:04 ` [PATCH v3 04/10] clk: sunxi-ng: add support for Allwinner H5 SoC Maxime Ripard
[not found] ` <20170129023331.62106-6-icenowy@aosc.xyz>
2017-01-30 1:42 ` [PATCH v3 05/10] arm: dts: sun8i: split Allwinner H3 .dtsi André Przywara
2017-01-30 9:09 ` Maxime Ripard [this message]
2017-01-30 9:06 ` Maxime Ripard
[not found] ` <20170129023331.62106-7-icenowy@aosc.xyz>
2017-01-30 9:09 ` [PATCH v3 06/10] clk: sunxi-ng: remove transitional headers for dt-bindings Maxime Ripard
[not found] ` <20170129023331.62106-2-icenowy@aosc.xyz>
2017-01-30 15:23 ` [PATCH v3 01/10] drivers: pinctrl: add driver for Allwinner H5 SoC Linus Walleij
[not found] ` <20170129023331.62106-9-icenowy@aosc.xyz>
2017-01-30 16:42 ` [PATCH v3 08/10] dmaengine: sun6i: allow build on ARM64 platforms (sun50i) Vinod Koul
[not found] ` <3729521485800635@web23g.yandex.ru>
2017-01-31 3:32 ` Vinod Koul
2017-02-05 7:19 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130090910.cer2nvedq3tjleih@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=Mark.Rutland@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=icenowy@aosc.xyz \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).