From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752553AbdA3Ib7 (ORCPT ); Mon, 30 Jan 2017 03:31:59 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:42175 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbdA3Ib4 (ORCPT ); Mon, 30 Jan 2017 03:31:56 -0500 Date: Mon, 30 Jan 2017 09:24:00 +0100 From: Thomas Petazzoni To: Shailendra Verma Cc: Linus Walleij , Laxman Dewangan , Andreas Klinger , Sebastian Hesselbarth , Andrew Lunn , Jamie Lentin , Rob Herring , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma Subject: Re: [PATCH] Pinctrl: mvebu - Fix possible NULL derefrence. Message-ID: <20170130092400.589f6a93@free-electrons.com> In-Reply-To: <1485751903-29284-1-git-send-email-shailendra.v@samsung.com> References: <1485751903-29284-1-git-send-email-shailendra.v@samsung.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, 30 Jan 2017 10:21:43 +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma In practice, I don't see how of_match_device() can return NULL here. Indeed, those drivers only support Device Tree based probing, so of_match_device() will always return a non-NULL value. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com