From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752981AbdA3Mr5 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Jan 2017 07:47:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49288 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752818AbdA3Mrt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jan 2017 07:47:49 -0500
Date: Mon, 30 Jan 2017 13:39:29 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 1/2] perf tools: Use zfree() instead of free() in
 parse-events.c
Message-ID: <20170130123929.GA11887@krava>
References: <1485753819-12857-1-git-send-email-treeze.taeung@gmail.com>
 <20170130090159.GC22029@krava>
 <f6d1a248-daee-afa9-c71c-5688aa76afdb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f6d1a248-daee-afa9-c71c-5688aa76afdb@gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 30 Jan 2017 12:39:33 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jan 30, 2017 at 07:37:58PM +0900, Taeung Song wrote:
> 
> 
> On 01/30/2017 06:01 PM, Jiri Olsa wrote:
> > On Mon, Jan 30, 2017 at 02:23:38PM +0900, Taeung Song wrote:
> > > Currently there are several parts not checking NULL
> > > after allocating with zalloc() or asigning NULL value
> > > to a pointer variable after doing free().
> > > 
> > > So I fill in code checking NULL and
> > > use zfree() instead of free().
> > 
> > can't see directly reasons for zfree usage,
> > but it looks reasonable.. do you have any
> > crash reports due to missing zfree?
> 
> No, Just I read source code util/parse-events.c
> And I found several insufficiency, shortcoming
> not checking NULL or assigning NULL value to a pointer
> variable after free().
> So, I think we can use zfree() insteadof free()+assigning NULL.

ok

> 
> Change commit message to be more appropriate ?

that's always good idea ;-)

thanks,
jirka

> 
> Thanks,
> Taeung
>