From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353AbdA3NPj (ORCPT ); Mon, 30 Jan 2017 08:15:39 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40252 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752783AbdA3NPe (ORCPT ); Mon, 30 Jan 2017 08:15:34 -0500 Date: Mon, 30 Jan 2017 12:52:28 +0000 From: Mark Brown To: Geert Uytterhoeven Cc: Shailendra Verma , linux-spi , "linux-kernel@vger.kernel.org" , p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma Message-ID: <20170130125228.t4tva3x6y3gavn7w@sirena.org.uk> References: <1485752113-29581-1-git-send-email-shailendra.v@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zhkxzp5gdoz74oub" Content-Disposition: inline In-Reply-To: X-Cookie: A man's best friend is his dogma. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi - Fix possible NULL derefrence. X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zhkxzp5gdoz74oub Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 30, 2017 at 11:00:28AM +0100, Geert Uytterhoeven wrote: > On Mon, Jan 30, 2017 at 5:55 AM, Shailendra Verma > wrote: > > of_match_device could return NULL, and so can cause a NULL > > pointer dereference later. > Can it? The driver uses DT exclusively. > There is no legacy platform code creating "mxs-spi" platform devices. Yeah, the changelogs on these aren't very good - there's no present risk, though future changes could potentially cause an issue so it's not unreasonable to do it defensively. --zhkxzp5gdoz74oub Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAliPNwsACgkQJNaLcl1U h9D/2gf/cse6+jFN10kKzXnNohcBuQe/GTkO7nQp8nOTCaJyLtEKSobtub4ADDo0 82SkuTagIqvqtzDsga6QzSttfaa03jHYvVio1ZSOJ7RUuHDlxDRk0aGFYWOt4vTI pnowgRUPA17FONLNVL4NvY/owOOZdyMwWc1SJMMfn49MErmzH4W7mgCBqJkrjt+e oFXbdUolLrKrhre4VZk/snXf5Fjwt9rmEoo2/IBcX9miEdYDh/22DbMEW2GVYAga gcBS9+0WexpFXgdbZ5F4wWu+KUMvpJU+p4+Q3VDyZCrDatgTFRzznfZ+26Wxwxuu AF9AeesBZm8fDUWPYKN3c93c5GMh4Q== =Sd1U -----END PGP SIGNATURE----- --zhkxzp5gdoz74oub--