From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753947AbdA3SDR (ORCPT ); Mon, 30 Jan 2017 13:03:17 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:34113 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538AbdA3SDP (ORCPT ); Mon, 30 Jan 2017 13:03:15 -0500 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Tony Lindgren Subject: Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data Date: Mon, 30 Jan 2017 19:03:01 +0100 User-Agent: KMail/1.13.7 (Linux/3.13.0-107-generic; KDE/4.14.2; x86_64; ; ) Cc: Pavel Machek , Kalle Valo , Arend Van Spriel , Ming Lei , "Luis R. Rodriguez" , "Greg Kroah-Hartman" , David Gnedt , Michal Kazior , Daniel Wagner , Sebastian Reichel , Ivaylo Dimitrov , Aaro Koskinen , Grazvydas Ignotas , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org References: <20170127194012.GE20571@amd> <20170130175309.GY7403@atomide.com> In-Reply-To: <20170130175309.GY7403@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1794404.FCbjbtiOYb"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201701301903.02043@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1794404.FCbjbtiOYb Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Monday 30 January 2017 18:53:09 Tony Lindgren wrote: > * Pavel Machek [170127 11:41]: > > On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > > > Pali Roh=C3=A1r writes: > > > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > > > >> Pali Roh=C3=A1r writes: > > > >> > 2) It was already tested that example NVS data can be used > > > >> > for N900 e.g. for SSH connection. If real correct data are > > > >> > not available it is better to use at least those example > > > >> > (and probably log warning message) so user can connect via > > > >> > SSH and start investigating where is problem. > > > >>=20 > > > >> I disagree. Allowing default calibration data to be used can > > > >> be unnoticed by user and left her wondering why wifi works so > > > >> badly. > > > >=20 > > > > So there are only two options: > > > >=20 > > > > 1) Disallow it and so these users will have non-working wifi. > > > >=20 > > > > 2) Allow those data to be used as fallback mechanism. > > > >=20 > > > > And personally I'm against 1) because it will break wifi > > > > support for *all* Nokia N900 devices right now. > > >=20 > > > All two of them? :) > >=20 > > Umm. You clearly want a flock of angry penguins at your doorsteps > > :-). >=20 > Well this silly issue of symlinking and renaming nvs files in a > standard Linux distro was also hitting me on various devices with > wl12xx/wl18xx trying to use the same rootfs. wl12xx/wl18xx have probably exactly same problem as wl1251. > Why don't we just set a custom compatible property for n900 that then > picks up some other nvs file instead of the default? But that still does not solve this problem correctly. Every n900 device=20 have different NVS file. If we allow to load firmware directly from VFS=20 without userspace helper we would see again same problem. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1794404.FCbjbtiOYb Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAliPf9YACgkQi/DJPQPkQ1JbCQCgzTXVLMnh/oT3/hxkmso53HTS oIcAnRVQbs50sOAxgZxD+5flps5f44O7 =6Ie3 -----END PGP SIGNATURE----- --nextPart1794404.FCbjbtiOYb--