From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932439AbdA3TiA (ORCPT ); Mon, 30 Jan 2017 14:38:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37478 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932364AbdA3Th6 (ORCPT ); Mon, 30 Jan 2017 14:37:58 -0500 Date: Mon, 30 Jan 2017 20:37:57 +0100 From: Greg Kroah-Hartman To: Shailendra Verma Cc: Cory Tusar , Vladimir Zapolskiy , Srinivas Kandagatla , Andrew Lunn , linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma Subject: Re: [PATCH] Misc: eeprom - Fix possible NULL derefrence. Message-ID: <20170130193757.GC27138@kroah.com> References: <1485515551-3191-1-git-send-email-shailendra.v@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485515551-3191-1-git-send-email-shailendra.v@samsung.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2017 at 04:42:31PM +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma > --- > drivers/misc/eeprom/eeprom_93xx46.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c > index 94cc035..6555975 100644 > --- a/drivers/misc/eeprom/eeprom_93xx46.c > +++ b/drivers/misc/eeprom/eeprom_93xx46.c > @@ -381,6 +381,11 @@ static int eeprom_93xx46_probe_dt(struct spi_device *spi) > enum of_gpio_flags of_flags; > int ret; > > + if (!of_id) { > + dev_err(&spi->dev, "Error: No device match found\n"); > + return -ENODEV; > + } > + Also dropped due to this not being possible. greg k-h