From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754343AbdA3Ubr (ORCPT ); Mon, 30 Jan 2017 15:31:47 -0500 Received: from mail-qk0-f169.google.com ([209.85.220.169]:36317 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbdA3Ubm (ORCPT ); Mon, 30 Jan 2017 15:31:42 -0500 Date: Mon, 30 Jan 2017 15:30:35 -0500 From: Sean Paul To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, Daniel Vetter , David Airlie , Jani Nikula , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: remove unnecessary fault wrappers Message-ID: <20170130203035.GS20076@art_vandelay> References: <1485804002-27363-1-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485804002-27363-1-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2017 at 12:20:02PM -0700, Ross Zwisler wrote: > The fault wrappers drm_vm_fault(), drm_vm_shm_fault(), drm_vm_dma_fault() > and drm_vm_sg_fault() used to provide extra logic beyond what was in the > "drm_do_*" versions of these functions, but as of this commit: > > commit ca0b07d9a969 ("drm: convert drm from nopage to fault.") > > They are just unnecessary wrappers that do nothing. Remove them. Can we rename the drm_do_* functions to remove "do_" instead? I don't think it adds anything and this seems like a good time to fix that. Sean > > Signed-off-by: Ross Zwisler > --- > drivers/gpu/drm/drm_vm.c | 28 ++++------------------------ > 1 file changed, 4 insertions(+), 24 deletions(-) > > diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c > index bae6e26..e677b11 100644 > --- a/drivers/gpu/drm/drm_vm.c > +++ b/drivers/gpu/drm/drm_vm.c > @@ -349,50 +349,30 @@ static int drm_do_vm_sg_fault(struct vm_fault *vmf) > return 0; > } > > -static int drm_vm_fault(struct vm_fault *vmf) > -{ > - return drm_do_vm_fault(vmf); > -} > - > -static int drm_vm_shm_fault(struct vm_fault *vmf) > -{ > - return drm_do_vm_shm_fault(vmf); > -} > - > -static int drm_vm_dma_fault(struct vm_fault *vmf) > -{ > - return drm_do_vm_dma_fault(vmf); > -} > - > -static int drm_vm_sg_fault(struct vm_fault *vmf) > -{ > - return drm_do_vm_sg_fault(vmf); > -} > - > /** AGP virtual memory operations */ > static const struct vm_operations_struct drm_vm_ops = { > - .fault = drm_vm_fault, > + .fault = drm_do_vm_fault, > .open = drm_vm_open, > .close = drm_vm_close, > }; > > /** Shared virtual memory operations */ > static const struct vm_operations_struct drm_vm_shm_ops = { > - .fault = drm_vm_shm_fault, > + .fault = drm_do_vm_shm_fault, > .open = drm_vm_open, > .close = drm_vm_shm_close, > }; > > /** DMA virtual memory operations */ > static const struct vm_operations_struct drm_vm_dma_ops = { > - .fault = drm_vm_dma_fault, > + .fault = drm_do_vm_dma_fault, > .open = drm_vm_open, > .close = drm_vm_close, > }; > > /** Scatter-gather virtual memory operations */ > static const struct vm_operations_struct drm_vm_sg_ops = { > - .fault = drm_vm_sg_fault, > + .fault = drm_do_vm_sg_fault, > .open = drm_vm_open, > .close = drm_vm_close, > }; > -- > 2.7.4 -- Sean Paul, Software Engineer, Google / Chromium OS