From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbdA3Jl0 (ORCPT ); Mon, 30 Jan 2017 04:41:26 -0500 Received: from ozlabs.org ([103.22.144.67]:51393 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752649AbdA3JlY (ORCPT ); Mon, 30 Jan 2017 04:41:24 -0500 Date: Mon, 30 Jan 2017 20:41:02 +1100 From: Stephen Rothwell To: Andrew Donnellan Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, paulmck@linux.vnet.ibm.com, benh@kernel.crashing.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: [PATCH] powerpc: sort Kconfig selects under CONFIG_PPC Message-ID: <20170130204102.423cebea@canb.auug.org.au> In-Reply-To: <20170130093002.22180-1-andrew.donnellan@au1.ibm.com> References: <87y3xtw62l.fsf@concordia.ellerman.id.au> <20170130093002.22180-1-andrew.donnellan@au1.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On Mon, 30 Jan 2017 20:30:02 +1100 Andrew Donnellan wrote: > > config PPC has a lot of selects under it. They're not sorted in any > particular order, leading to merge conflicts when adding items at the end. > > Sort them alphabetically. Excellent, thanks. > Suggested-by: Michael Ellerman > Signed-off-by: Andrew Donnellan > --- > > On top of linux-next 20170130 Probably best done on top of powerpc-next and I can cope with the conflicts one more time. > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index 689cf9218b21..570195c8a86a 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -80,91 +80,91 @@ config ARCH_HAS_DMA_SET_COHERENT_MASK > config PPC Could we add a comment just above asking that the selects be kept in order? > bool > default y > - select BUILDTIME_EXTABLE_SORT > + select ARCH_HAS_DEVMEM_IS_ALLOWED > + select ARCH_HAS_DMA_SET_COHERENT_MASK -- Cheers, Stephen Rothwell