From: Russell King - ARM Linux <email@example.com> To: Guenter Roeck <firstname.lastname@example.org> Cc: Stephen Boyd <email@example.com>, Dmitry Torokhov <firstname.lastname@example.org>, Michael Turquette <email@example.com>, Viresh Kumar <firstname.lastname@example.org>, Andy Shevchenko <email@example.com>, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v2] clk: add more managed APIs Date: Mon, 30 Jan 2017 21:42:28 +0000 [thread overview] Message-ID: <20170130214227.GI27312@n2100.armlinux.org.uk> (raw) In-Reply-To: <20170130192214.GC11199@roeck-us.net> On Mon, Jan 30, 2017 at 11:22:14AM -0800, Guenter Roeck wrote: > Maybe the additional calls make sense; I can imagine they would. > However, I personally would be a bit wary of changing the initialization > order of multi-clock initializations, and I am not sure how a single call > could address setting the rate ([devm_]clk_get_setrate_prepare_enable() > seems like a bit too much). > > [ On a side note, why is there no clk_get_prepare_enable() and > clk_get_prepare() ? Maybe it would be better to introduce those > together with the matching devm_ functions in a separate patch > if they are useful. ] If you take the view that trying to keep clocks disabled is a good way to save power, then you'd have the clk_prepare() or maybe clk_prepare_enable() in your runtime PM resume handler, or maybe even deeper in the driver... the original design goal of the clk API was to allow power saving and clock control. With that in mind, getting and enabling the clock together in the probe function didn't make sense. I feel that aspect has been somewhat lost, and people now regard much of the clk API as a bit of a probe-time nusience. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.
next prev parent reply other threads:[~2017-01-30 21:43 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-28 18:40 [PATCH] " Dmitry Torokhov 2017-01-28 19:03 ` Russell King - ARM Linux 2017-01-28 19:22 ` Dmitry Torokhov 2017-01-28 21:44 ` Guenter Roeck 2017-01-28 23:39 ` Russell King - ARM Linux 2017-01-29 16:00 ` Guenter Roeck 2017-01-29 18:07 ` [PATCH v2] " Dmitry Torokhov 2017-01-29 18:31 ` Guenter Roeck 2017-01-30 18:55 ` Stephen Boyd 2017-01-30 19:22 ` Guenter Roeck 2017-01-30 21:42 ` Russell King - ARM Linux [this message] 2017-01-30 21:58 ` Dmitry Torokhov 2017-01-30 22:25 ` Russell King - ARM Linux 2017-01-30 22:51 ` Guenter Roeck 2017-01-31 8:43 ` Geert Uytterhoeven 2017-01-31 0:59 ` Dmitry Torokhov 2017-01-31 17:20 ` Guenter Roeck 2017-01-31 18:26 ` Dmitry Torokhov 2017-01-31 19:34 ` Guenter Roeck 2017-01-31 0:57 ` [PATCH v3] " Dmitry Torokhov 2017-02-07 3:51 ` Dmitry Torokhov 2017-02-14 19:44 ` Stephen Boyd 2017-02-14 19:55 ` Dmitry Torokhov 2017-02-14 20:31 ` Guenter Roeck 2017-02-14 20:01 ` Russell King - ARM Linux
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170130214227.GI27312@n2100.armlinux.org.uk \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2] clk: add more managed APIs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).