From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753280AbdA3WZt (ORCPT ); Mon, 30 Jan 2017 17:25:49 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:45578 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbdA3WZs (ORCPT ); Mon, 30 Jan 2017 17:25:48 -0500 Date: Mon, 30 Jan 2017 22:25:35 +0000 From: Russell King - ARM Linux To: Dmitry Torokhov Cc: Guenter Roeck , Stephen Boyd , Michael Turquette , Viresh Kumar , Andy Shevchenko , linux-clk@vger.kernel.org, lkml Subject: Re: [PATCH v2] clk: add more managed APIs Message-ID: <20170130222534.GJ27312@n2100.armlinux.org.uk> References: <20170128184047.GA24957@dtor-ws> <20170128190309.GN27312@n2100.armlinux.org.uk> <20170128192207.GA38136@dtor-ws> <64ed0890-14f6-42ff-66b1-60f7b3d7d02f@roeck-us.net> <20170128233911.GO27312@n2100.armlinux.org.uk> <20170129180743.GA10917@dtor-ws> <20170130185551.GM8801@codeaurora.org> <20170130192214.GC11199@roeck-us.net> <20170130214227.GI27312@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2017 at 01:58:05PM -0800, Dmitry Torokhov wrote: > FWIW I do not think that kitchen sink calls, like > "devm_clk_get_prepare_set_rate_enable" are helpful. Resource > acquisition and use of said resource are logically separate. That alone is an argument against devm_clk_get_prepare_enable() in so far that drivers should really get all their resources before they start to enable anything. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.