From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751323AbdAaQnE (ORCPT ); Tue, 31 Jan 2017 11:43:04 -0500 Received: from mail.kernel.org ([198.145.29.136]:37914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdAaQm6 (ORCPT ); Tue, 31 Jan 2017 11:42:58 -0500 Date: Tue, 31 Jan 2017 13:42:03 -0300 From: Arnaldo Carvalho de Melo To: Joe Stringer Cc: Wang Nan , ast@fb.com, Daniel Borkmann , LKML , netdev Subject: Re: [PATCHv3 perf/core 1/6] tools lib bpf: Add BPF program pinning APIs. Message-ID: <20170131164203.GC4529@kernel.org> References: <20170126212001.14103-1-joe@ovn.org> <20170126212001.14103-2-joe@ovn.org> <20170130202506.GF4546@kernel.org> <20170130202813.GG4546@kernel.org> <20170131005805.GI4546@kernel.org> <20170131160827.GA4529@kernel.org> <20170131161320.GB4529@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170131161320.GB4529@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jan 31, 2017 at 01:13:20PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jan 31, 2017 at 01:08:27PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Jan 30, 2017 at 09:58:05PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Mon, Jan 30, 2017 at 01:16:18PM -0800, Joe Stringer escreveu: > > > > On 30 January 2017 at 12:28, Arnaldo Carvalho de Melo wrote: > > > > > --- > > > > > Thus, a return value of size or more means that the output was > > > > > truncated. > > > > > --- > > > > > > > Good spotting, I looked over the committed versions and tested them, > > > > they seem good to me. Thanks! > > > > > > Thanks for checking, will push Ingo's way after a battery of extra > > > tests, tomorrow, > > > > Which failed for centos:5, centos:6, centos:7, debian:7, debian:8, > > debian:experimental and others, I stopped the test at this point, > > working on fixing it. > > > > All seems related to: > > > > libbpf.c:1267: error: 'BPF_FS_MAGIC' undeclared (first use in this function) > > libbpf.c:1267: error: (Each undeclared identifier is reported only once > > libbpf.c:1267: error: for each function it appears in.) > > We need to carry a tools/include/uapi/linux/magic.c copy, check if it > drifts, remove the ifdefs for _FS_MAGIC defines from tools/ and use that > instead, etc, till then I'll just add the ifdef to libbpf.c. After also removing that #include line, that is not used anywhere else in tools/{perf,include,lib}/ it is going further: [root@jouet ~]# time dm 1 83.120412349 alpine:3.4: Ok 2 35.486456929 android-ndk:r12b-arm: Ok 3 85.384259996 archlinux:latest: Ok 4 49.518031326 centos:5: Ok 5 70.417375831 centos:6: Ok 6 87.033156092 centos:7: Ok 31 more to go :-) - Arnaldo