From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751200AbdAaVFU (ORCPT ); Tue, 31 Jan 2017 16:05:20 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:33033 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbdAaVFS (ORCPT ); Tue, 31 Jan 2017 16:05:18 -0500 Date: Tue, 31 Jan 2017 22:05:17 +0100 From: Alexandre Belloni To: Chen-Yu Tsai Cc: Alessandro Zummo , Maxime Ripard , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: sun6i: Fix compatibility with old DT binding Message-ID: <20170131210517.jkhwe3e2d7mjfgti@piout.net> References: <20170129101343.7222-1-wens@csie.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170129101343.7222-1-wens@csie.org> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/01/2017 at 18:13:43 +0800, Chen-Yu Tsai wrote: > Commit 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator") adds > a new clock for the rtc block with a 2 step probe mechanism. To share > the register region between both the clock and rtc instance, a static > pointer is used to keep the related data structure. > > To preserve compatibility with the old binding, the data structure > should be saved as soon as the registers are mapped in, regardless > of the presence of the clock bindings, so that the rtc device can > retrieve it when it is probed. > > This fixes the rtc device not probing when we use the updated driver > with an old device tree blob. > > Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator") > Signed-off-by: Chen-Yu Tsai > --- > drivers/rtc/rtc-sun6i.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com