From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752777AbdBAQhG (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Feb 2017 11:37:06 -0500
Received: from mail.kernel.org ([198.145.29.136]:45026 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751018AbdBAQhF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Feb 2017 11:37:05 -0500
Date: Wed, 1 Feb 2017 11:37:00 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Petr Mladek <pmladek@suse.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
        Calvin Owens <calvinowens@fb.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Hurley <peter@hurleysoftware.com>, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi
 contexts
Message-ID: <20170201113700.5b464143@gandalf.local.home>
In-Reply-To: <20161227141611.940-6-sergey.senozhatsky@gmail.com>
References: <20161227141611.940-1-sergey.senozhatsky@gmail.com>
        <20161227141611.940-6-sergey.senozhatsky@gmail.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 27 Dec 2016 23:16:08 +0900
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:

> Account lost messages in pritk-safe and printk-safe-nmi
> contexts and report those numbers during printk_safe_flush().
> 
> The patch also moves lost message counter to struct
> `printk_safe_seq_buf' instead of having dedicated static
> counters - this simplifies the code.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---

This looks fine, but I'm curious if you tested it. That is, added a
bunch of printks to overflow the buffer. IIRC, I did it to the original
nmi code. If you haven't you may want to just to make sure it works. I
can also test it too if I get some time.

-- Steve