From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754407AbdBASvK (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Feb 2017 13:51:10 -0500
Received: from mail.kernel.org ([198.145.29.136]:42142 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752759AbdBASvI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Feb 2017 13:51:08 -0500
Date: Wed, 1 Feb 2017 13:51:03 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Jason Baron <jbaron@akamai.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v3] jump_label: reduce the size of struct static_key
Message-ID: <20170201135103.6b9da1a7@gandalf.local.home>
In-Reply-To: <1485900043-23183-1-git-send-email-jbaron@akamai.com>
References: <1485900043-23183-1-git-send-email-jbaron@akamai.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 31 Jan 2017 17:00:43 -0500
Jason Baron <jbaron@akamai.com> wrote:

> --- a/kernel/jump_label.c
> +++ b/kernel/jump_label.c
> @@ -236,12 +236,27 @@ void __weak __init_or_module arch_jump_label_transform_static(struct jump_entry
>  
>  static inline struct jump_entry *static_key_entries(struct static_key *key)
>  {
> -	return (struct jump_entry *)((unsigned long)key->entries & ~JUMP_TYPE_MASK);

I wonder if we should add:

	WARN_ON_ONCE(key->type & JUMP_TYPE_LINKED);

> +	return (struct jump_entry *)(key->type & ~JUMP_TYPE_MASK);
>  }
>  

[...]

>  
> +static inline struct static_key_mod *static_key_mod(struct static_key *key)
> +{

	WARN_ON_ONCE(!(key->type & JUMP_TYPE_LINKED));

> +	return (struct static_key_mod *)(key->type & ~JUMP_TYPE_MASK);
> +}
> +

-- Steve