From: Rob Herring <robh@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: jic23@kernel.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
mark.rutland@arm.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, lars@metafoo.de, knaack.h@gmx.de,
pmeerw@pmeerw.net, benjamin.gaignard@linaro.org,
benjamin.gaignard@st.com
Subject: Re: [PATCH 3/5] Documentation: dt: iio: document stm32 exti trigger
Date: Wed, 1 Feb 2017 10:35:00 -0600 [thread overview]
Message-ID: <20170201163500.ivxnxejurhzzoctl@rob-hp-laptop> (raw)
In-Reply-To: <1485784663-19505-4-git-send-email-fabrice.gasnier@st.com>
On Mon, Jan 30, 2017 at 02:57:41PM +0100, Fabrice Gasnier wrote:
> Add dt documentation for st,stm32-exti-trigger.
> EXTi gpio signal can be routed internally as trigger source for various
s/gpio/GPIO/
> IPs (e.g. for ADC or DAC conversions).
Please use "dt-bindings: iio:" for the subject prefix.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> .../bindings/iio/trigger/st,stm32-exti-trigger.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/trigger/st,stm32-exti-trigger.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/trigger/st,stm32-exti-trigger.txt b/Documentation/devicetree/bindings/iio/trigger/st,stm32-exti-trigger.txt
> new file mode 100644
> index 0000000..ebf2645
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/trigger/st,stm32-exti-trigger.txt
> @@ -0,0 +1,17 @@
> +STMicroelectronics STM32 EXTI trigger bindings
> +
> +EXTi gpio signal can be routed internally as trigger source for various
s/gpio/GPIO/
> +IPs (e.g. for ADC or DAC conversions).
> +
> +Contents of a stm32 exti trigger root node:
Drop "root"
> +-------------------------------------------
> +Required properties:
> +- compatible: Should be "st,stm32-exti-trigger"
This whole binding looks a bit suspicious. Is this actually a h/w block?
What makes it stm32 specific? Seems like the gpio properties should just
be part of the ADC or DAC that they trigger.
> +- extiN-gpio: optional gpio line that may be used as external trigger source
-gpios is the preferred form.
> + (e.g. N may be 0..15. For example, exti11-gpio can trig ADC on stm32f4).
> +
> +Example:
> + triggers {
> + compatible = "st,stm32-exti-trigger";
> + exti11-gpio=<&gpioa 11 0>;
spaces around the "=".
> + };
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-02-01 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 13:57 [PATCH 0/5] Add EXTI GPIO trigger support to STM32 ADC Fabrice Gasnier
2017-01-30 13:57 ` [PATCH 1/5] Documentation: dt: iio: document stm32 adc trigger polarity Fabrice Gasnier
2017-01-30 13:57 ` [PATCH 2/5] iio: adc: stm32: add dt option to set default " Fabrice Gasnier
2017-01-30 13:57 ` [PATCH 3/5] Documentation: dt: iio: document stm32 exti trigger Fabrice Gasnier
2017-02-01 16:35 ` Rob Herring [this message]
2017-02-02 9:19 ` Fabrice Gasnier
2017-02-02 15:45 ` Rob Herring
2017-02-03 10:37 ` Fabrice Gasnier
2017-02-03 19:11 ` Linus Walleij
2017-01-30 13:57 ` [PATCH 4/5] iio: trigger: add support for STM32 EXTI triggers Fabrice Gasnier
2017-01-30 13:57 ` [PATCH 5/5] iio: adc: stm32: add exti11 gpio trigger source Fabrice Gasnier
2017-01-30 14:09 ` [PATCH 0/5] Add EXTI GPIO trigger support to STM32 ADC Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201163500.ivxnxejurhzzoctl@rob-hp-laptop \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).