linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tobin Harding <me@tobin.cc>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Jan Kara <jack@suse.cz>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 2/4] mm: Fix checkpatch warnings, whitespace
Date: Thu, 2 Feb 2017 14:51:17 +1100	[thread overview]
Message-ID: <20170202035117.GA15650@eros> (raw)
In-Reply-To: <alpine.DEB.2.10.1702011648160.58909@chino.kir.corp.google.com>

On Wed, Feb 01, 2017 at 04:48:28PM -0800, David Rientjes wrote:
> On Thu, 2 Feb 2017, Tobin C. Harding wrote:
> 
> > @@ -3696,8 +3695,8 @@ int handle_mm_fault(struct vm_area_struct *vma, unsigned long address,
> >                   * VM_FAULT_OOM), there is no need to kill anything.
> >                   * Just clean up the OOM state peacefully.
> >                   */
> > -                if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM))
> > -                        mem_cgroup_oom_synchronize(false);
> > +		if (task_in_memcg_oom(current) && !(ret & VM_FAULT_OOM))
> > +			mem_cgroup_oom_synchronize(false);
> >  	}
> >  
> >  	/*
> 
> The comment suffers from the same problem.

The comment is fixed in the next patch of the set. The fixes are in
separate patches because one was a checkpatch warning and one was an
error.

Any comments on the structure of the patchset most appreciated.


thanks,
Tobin.

  reply	other threads:[~2017-02-02  3:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 23:37 [PATCH 0/4] mm: trivial sparse and checkpatch fixes Tobin C. Harding
2017-02-01 23:37 ` [PATCH 1/4] mm: Fix sparse, use plain integer as NULL pointer Tobin C. Harding
2017-02-02 13:08   ` Kirill A. Shutemov
2017-02-01 23:37 ` [PATCH 2/4] mm: Fix checkpatch warnings, whitespace Tobin C. Harding
2017-02-02  0:48   ` David Rientjes
2017-02-02  3:51     ` Tobin Harding [this message]
2017-02-01 23:37 ` [PATCH 3/4] mm: Fix checkpatch errors, whitespace errors Tobin C. Harding
2017-02-01 23:37 ` [PATCH 4/4] mm: Fix checkpatch warning, extraneous braces Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170202035117.GA15650@eros \
    --to=me@tobin.cc \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=rientjes@google.com \
    --cc=ross.zwisler@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).