From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751218AbdBBGiv (ORCPT ); Thu, 2 Feb 2017 01:38:51 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:32802 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbdBBGiR (ORCPT ); Thu, 2 Feb 2017 01:38:17 -0500 From: David Carrillo-Cisneros To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo , Jiri Olsa , Alexander Shishkin , Wang Nan , He Kuang , Michal Marek , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Stephane Eranian , Paul Turner , David Carrillo-Cisneros Subject: [PATCH 3/4] tools lib feature: Do not redefine compiler configuration Date: Wed, 1 Feb 2017 22:38:03 -0800 Message-Id: <20170202063804.94027-4-davidcc@google.com> X-Mailer: git-send-email 2.11.0.483.g087da7b7c-goog In-Reply-To: <20170202063804.94027-1-davidcc@google.com> References: <20170202063804.94027-1-davidcc@google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Feature detection redefines CC, CCX and PKG_CONFIG, making the output of feature detection inconsistent with the actual features available during compilation when the above variables are used. Fix it by using conditional assignment. Signed-off-by: David Carrillo-Cisneros --- tools/build/feature/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile index 3dd2c600d250..d39e76f3a063 100644 --- a/tools/build/feature/Makefile +++ b/tools/build/feature/Makefile @@ -52,9 +52,9 @@ FILES= \ FILES := $(addprefix $(OUTPUT),$(FILES)) -CC := $(CROSS_COMPILE)gcc -MD -CXX := $(CROSS_COMPILE)g++ -MD -PKG_CONFIG := $(CROSS_COMPILE)pkg-config +CC ?= $(CROSS_COMPILE)gcc -MD +CXX ?= $(CROSS_COMPILE)g++ -MD +PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config LLVM_CONFIG ?= llvm-config all: $(FILES) -- 2.11.0.483.g087da7b7c-goog