From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751094AbdBBJHg (ORCPT ); Thu, 2 Feb 2017 04:07:36 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:33389 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbdBBJHe (ORCPT ); Thu, 2 Feb 2017 04:07:34 -0500 Date: Thu, 2 Feb 2017 10:07:22 +0100 From: Peter Zijlstra To: Sergey Senozhatsky Cc: Petr Mladek , Jan Kara , Ross Zwisler , Sergey Senozhatsky , Ross Zwisler , Andrew Morton , Linus Torvalds , Tejun Heo , Calvin Owens , Steven Rostedt , Ingo Molnar , Andy Lutomirski , Peter Hurley , LKML Subject: Re: [PATCHv7 6/8] printk: use printk_safe buffers in printk Message-ID: <20170202090722.GW6515@twins.programming.kicks-ass.net> References: <20161227141611.940-1-sergey.senozhatsky@gmail.com> <20161227141611.940-7-sergey.senozhatsky@gmail.com> <20170201090625.GC11567@quack2.suse.cz> <20170201093739.GT6515@twins.programming.kicks-ass.net> <20170201153910.GL6620@pathway.suse.cz> <20170202021134.GC1954@jagdpanzerIV.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170202021134.GC1954@jagdpanzerIV.localdomain> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 02, 2017 at 11:11:34AM +0900, Sergey Senozhatsky wrote: > On (02/01/17 16:39), Petr Mladek wrote: > [..] > > I guess that you are talking about the introduction of > > #define SCHED_WARN_ON(x) WARN_ONCE(x, #x) > > my guess would be that Jan was talking about printk_deferred() patch. > it's on my TODO list. > > I want to entirely remove console_sem and scheduler out of printk() path. > that's the only way to make printk() deadlock safe. And useless.. if you never get around to the 'later' part where you print the content. This way you still mostly get the output. And no, its not the only way, see my printk->early_printk patches. early serial console only does a loop over outb, impossible to mess that up.