From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751455AbdBBLNX (ORCPT ); Thu, 2 Feb 2017 06:13:23 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:41364 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbdBBLMD (ORCPT ); Thu, 2 Feb 2017 06:12:03 -0500 From: Ravi Bangoria To: acme@redhat.com, alexis.berlemont@gmail.com, linux-kernel@vger.kernel.org Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, mpe@ellerman.id.au, naveen.n.rao@linux.vnet.ibm.com, mhiramat@kernel.org, maddy@linux.vnet.ibm.com, Ravi Bangoria Subject: [PATCH 0/5] perf/sdt: Argument support for x86 and powepc Date: Thu, 2 Feb 2017 16:41:38 +0530 X-Mailer: git-send-email 2.9.3 In-Reply-To: <20161214000732.1710-1-alexis.berlemont@gmail.com> References: <20161214000732.1710-1-alexis.berlemont@gmail.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17020211-0004-0000-0000-00000533BDA9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17020211-0005-0000-0000-0000132CD84C Message-Id: <20170202111143.14319-1-ravi.bangoria@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-02_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702020105 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The v5 patchset for sdt marker argument support for x86 [1] has couple of issues. For example, it still has x86 specific code in general code. It lacks support for rNN (with size postfix b/w/d), %rsp, %esp, %sil etc. registers and such sdt markers are failing at 'perf probe'. It also fails to convert arguments having no offset but still surrounds register with parenthesis for ex. 8@(%rdi) is converted to +(%di):u64 which is rejected by uprobe_events. It's causing failure at 'perf probe' for all SDT events on all archs except x86. With this patchset, I've solved these issues. (patch 2,3) Also, existing perf shows misleading message when user tries to record sdt event without probing it. I've prepared patch for the same. (patch 1) Apart from that, I've also added logic to support arguments with sdt marker on powerpc. (patch 4) There are cases where uprobe definition of sdt event goes beyond current limit MAX_CMDLEN (256) and in such case perf fails with seg fault. I've solve this issue. (patch 5) Note: This patchset is prepared on top of Alexis' v5 series.[1] [1] http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1292251.html Ravi Bangoria (5): perf/sdt: Show proper hint perf/sdt/x86: Add renaming logic for rNN and other registers perf/sdt/x86: Move OP parser to tools/perf/arch/x86/ perf/sdt/powerpc: Add argument support perf/probe: Change MAX_CMDLEN tools/lib/api/fs/tracing_path.c | 16 +++- tools/perf/arch/powerpc/util/perf_regs.c | 115 ++++++++++++++++++++++++++ tools/perf/arch/x86/util/perf_regs.c | 137 ++++++++++++++++++++++++++++--- tools/perf/util/perf_regs.c | 9 +- tools/perf/util/perf_regs.h | 7 +- tools/perf/util/probe-event.c | 1 - tools/perf/util/probe-file.c | 129 ++++++++--------------------- 7 files changed, 294 insertions(+), 120 deletions(-) -- 2.9.3