From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Johannes Stezenbach <js@sig21.net>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Cohen <david.a.cohen@linux.intel.com>
Subject: Re: Cherryview wake up events
Date: Thu, 2 Feb 2017 13:35:08 +0200 [thread overview]
Message-ID: <20170202113508.GM2053@lahna.fi.intel.com> (raw)
In-Reply-To: <20170202111222.aoiwinw37jrquhbh@sig21.net>
On Thu, Feb 02, 2017 at 12:12:22PM +0100, Johannes Stezenbach wrote:
> On Thu, Feb 02, 2017 at 12:31:22PM +0200, Mika Westerberg wrote:
> > On Thu, Feb 02, 2017 at 10:52:00AM +0100, Johannes Stezenbach wrote:
> > > OperationRegion (GPOP, GeneralPurposeIo, Zero, 0x0100)
> > > Field (GPOP, ByteAcc, NoLock, Preserve)
> > > {
> > > Connection (
> > > GpioIo (Exclusive, PullDefault, 0x0000, 0x0000, IoRestrictionOutputOnly,
> > > "\\_SB.PCI0.I2C7.PMI2", 0x00, ResourceConsumer, ,
> > > )
> > > { // Pin list
> > > 0x0020
> > > }
> > > ),
> > > GMP0, 1,
> > > ...
> > > (repeat for many more pins)
> > >
> > > I guess it means it uses chv_gpio pins and can't work
> > > if the GPIO opregion is not registered?
> >
> > That is using GPIO pins of the PMI2 device - the PMIC GPIO driver, I
> > suppose.
> >
> > So in addition to the PMIC MFD driver, you need to have a GPIO driver
> > for Dollar Cove (I guess the quilt patch series included that as well?).
>
> Nope, I see it for AX288 but didn't find it for TI DCove. And in
> current Linus' tree axp288_cells[] doesn't include gpio so
> I concluded it's not needed... what am I missing?
So reading your DSDT there is that GPIO button array device \_SB.TBAD
which has one GpioInt() referencing \_SB.PCI0.I2C7.PMI2. I suppose that
is the power button GPIO.
In order to use that there needs to be a GPIO driver exposing those
GPIOs to other drivers. So it is definitely needed.
next prev parent reply other threads:[~2017-02-02 11:35 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 11:21 Cherryview wake up events Johannes Stezenbach
2016-09-19 11:56 ` Mika Westerberg
2016-09-19 20:36 ` Johannes Stezenbach
2016-09-20 9:18 ` Mika Westerberg
2016-09-20 10:14 ` Johannes Stezenbach
2016-09-20 10:40 ` Mika Westerberg
2016-09-20 15:59 ` Johannes Stezenbach
2016-09-20 21:11 ` Johannes Stezenbach
2016-09-21 9:06 ` Mika Westerberg
2016-09-21 9:16 ` Johannes Stezenbach
2016-09-23 8:19 ` Mika Westerberg
2016-09-23 9:59 ` Johannes Stezenbach
2016-10-05 12:46 ` Johannes Stezenbach
2016-10-05 13:05 ` Mika Westerberg
2016-12-04 18:52 ` Johannes Stezenbach
2016-12-05 11:06 ` Mika Westerberg
2017-01-24 9:41 ` Johannes Stezenbach
2017-01-24 11:14 ` Andy Shevchenko
2017-01-24 13:52 ` Johannes Stezenbach
2017-01-24 14:28 ` Andy Shevchenko
2017-01-24 19:23 ` Johannes Stezenbach
2017-01-25 9:29 ` Mika Westerberg
2017-01-26 22:56 ` Andy Shevchenko
2017-01-27 11:38 ` Johannes Stezenbach
2017-01-27 13:21 ` Andy Shevchenko
2017-01-27 13:30 ` Johannes Stezenbach
2017-01-30 20:57 ` Johannes Stezenbach
2017-01-30 22:05 ` Andy Shevchenko
2017-01-31 14:37 ` Johannes Stezenbach
2017-01-31 14:44 ` Mika Westerberg
2017-02-02 9:52 ` Johannes Stezenbach
2017-02-02 10:31 ` Mika Westerberg
2017-02-02 11:12 ` Johannes Stezenbach
2017-02-02 11:35 ` Mika Westerberg [this message]
2017-02-02 12:16 ` Mika Westerberg
2017-02-02 13:52 ` Johannes Stezenbach
2017-02-02 14:26 ` Mika Westerberg
2017-02-02 14:31 ` Johannes Stezenbach
2017-02-02 15:02 ` Mika Westerberg
2017-02-02 15:42 ` Johannes Stezenbach
2017-02-02 15:58 ` Mika Westerberg
2017-02-02 17:32 ` Johannes Stezenbach
2017-02-03 10:00 ` Mika Westerberg
2017-02-03 13:16 ` Johannes Stezenbach
2017-02-09 9:24 ` Johannes Stezenbach
2017-02-09 9:38 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202113508.GM2053@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=david.a.cohen@linux.intel.com \
--cc=js@sig21.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).