From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616AbdBBLxk (ORCPT ); Thu, 2 Feb 2017 06:53:40 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:49075 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbdBBLxh (ORCPT ); Thu, 2 Feb 2017 06:53:37 -0500 Date: Thu, 2 Feb 2017 12:53:23 +0100 From: Boris Brezillon To: Linus Walleij Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , Dmitry Torokhov , Linux Input , Bryan Wu , Richard Purdie , Jacek Anaszewski , "linux-leds@vger.kernel.org" , Tomi Valkeinen , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Russell King Subject: Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child() Message-ID: <20170202125323.29f6ecb5@bbrezillon> In-Reply-To: References: <1485790909-2915-1-git-send-email-boris.brezillon@free-electrons.com> <1485790909-2915-2-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Feb 2017 11:53:17 +0100 Linus Walleij wrote: > On Mon, Jan 30, 2017 at 4:41 PM, Boris Brezillon > wrote: > > > Rename devm_get_gpiod_from_child() into > > devm_fwnode_get_gpiod_from_child() to reflect the fact that this > > function is operating on a fwnode object. > > > > Signed-off-by: Boris Brezillon > > All right! So we settled we're gonna merge this and the other patch and > we have the necessary ACKs. > > This is unfortunately not applying because I have a bunch of other patches > touching the same files (that's why I think it's a good opportunity to > rename it now, as mentioned IIRC). > > Could you rebase this on the following branch: > https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/log/?h=ib-gpiod-flags While rebasing I noticed that you forgot to add the label parameter to the kernel doc header in commit b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request"). > > Then I will apply it on top of that immutable branch and pull it into the > devel branch of gpio so that we get it in and also have an immutable > branch with all changes if some other subsystem maintainer needs it > because of clashes. > > Yours, > Linus Walleij