From: Peter Zijlstra <peterz@infradead.org>
To: kbuild test robot <lkp@intel.com>
Cc: "J. R. Okajima" <hooanon05g@gmail.com>,
kbuild-all@01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] lockdep: new annotation lock_downgrade()
Date: Thu, 2 Feb 2017 19:45:40 +0100 [thread overview]
Message-ID: <20170202184540.GZ6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <201702030137.ONyfgEno%fengguang.wu@intel.com>
On Fri, Feb 03, 2017 at 01:59:37AM +0800, kbuild test robot wrote:
> Hi Okajima,
>
> [auto build test ERROR on tip/locking/core]
> [also build test ERROR on v4.10-rc6 next-20170202]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/J-R-Okajima/lockdep-consolidate-by-new-find_held_lock/20170203-010303
> config: x86_64-randconfig-x018-201705 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> kernel/locking/rwsem.c: In function 'downgrade_write':
> >> kernel/locking/rwsem.c:126:2: error: implicit declaration of function 'lock_downgrade' [-Werror=implicit-function-declaration]
> lock_downgrade(&sem->dep_map, _RET_IP_);
> ^~~~~~~~~~~~~~
> >> kernel/locking/rwsem.c:126:21: error: 'struct rw_semaphore' has no member named 'dep_map'
> lock_downgrade(&sem->dep_map, _RET_IP_);
> ^~
> cc1: some warnings being treated as errors
>
> vim +/lock_downgrade +126 kernel/locking/rwsem.c
>
> 120
> 121 /*
> 122 * downgrade write lock to read lock
> 123 */
> 124 void downgrade_write(struct rw_semaphore *sem)
> 125 {
> > 126 lock_downgrade(&sem->dep_map, _RET_IP_);
> 127
> 128 rwsem_set_reader_owned(sem);
> 129 __downgrade_write(sem);
This is what you need !LOCKDEP stubs for ;-)
next prev parent reply other threads:[~2017-02-02 18:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 21:25 Q: lockdep_assert_held_read() after downgrade_write() J. R. Okajima
2017-01-30 21:30 ` Jens Axboe
2017-01-31 10:36 ` Peter Zijlstra
2017-01-31 11:25 ` Peter Zijlstra
2017-01-31 14:23 ` Waiman Long
2017-01-31 14:26 ` Peter Zijlstra
2017-01-31 15:40 ` J. R. Okajima
2017-01-31 16:32 ` Peter Zijlstra
2017-02-02 16:33 ` J. R. Okajima
2017-02-02 16:38 ` [PATCH 1/3] lockdep: consolidate by new find_held_lock() J. R. Okajima
2017-02-02 16:38 ` [PATCH 2/3] lockdep: consolidate by new validate_held_lock() J. R. Okajima
2017-02-14 12:09 ` Peter Zijlstra
2017-03-16 11:25 ` [tip:locking/core] locking/lockdep: Factor out the validate_held_lock() helper function tip-bot for J. R. Okajima
2017-02-02 16:38 ` [PATCH 3/3] lockdep: new annotation lock_downgrade() J. R. Okajima
2017-02-02 17:59 ` kbuild test robot
2017-02-02 18:45 ` Peter Zijlstra [this message]
2017-02-02 21:05 ` J. R. Okajima
2017-02-14 12:11 ` Peter Zijlstra
2017-03-16 11:25 ` [tip:locking/core] locking/lockdep: Add new check to lock_downgrade() tip-bot for J. R. Okajima
2017-03-16 11:24 ` [tip:locking/core] locking/lockdep: Factor out the find_held_lock() helper function tip-bot for J. R. Okajima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202184540.GZ6515@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=hooanon05g@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).