From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <mawilcox@microsoft.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Miklos Szeredi <mszeredi@redhat.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix up huge_fault rename
Date: Thu, 2 Feb 2017 13:02:20 -0700 [thread overview]
Message-ID: <20170202200220.GA14747@linux.intel.com> (raw)
In-Reply-To: <20170202113625.702169-1-arnd@arndb.de>
On Thu, Feb 02, 2017 at 12:36:12PM +0100, Arnd Bergmann wrote:
> It looks like a search+replace accidentally change one function pointer that
> should have remained as before, as shown by this new warning:
>
> fs/ext4/file.c:279:1: error: 'ext4_dax_huge_fault' defined but not used [-Werror=unused-function]
>
> This reverts the one line of the changeset.
>
> Fixes: 80a841811260 ("mm,fs,dax: change ->pmd_fault to ->huge_fault")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> fs/ext4/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/file.c b/fs/ext4/file.c
> index ed22d20e843c..e1a581133aa1 100644
> --- a/fs/ext4/file.c
> +++ b/fs/ext4/file.c
> @@ -329,7 +329,7 @@ static int ext4_dax_pfn_mkwrite(struct vm_fault *vmf)
> static const struct vm_operations_struct ext4_dax_vm_ops = {
> .fault = ext4_dax_fault,
> .huge_fault = ext4_dax_fault,
> - .page_mkwrite = ext4_dax_fault,
> + .page_mkwrite = ext4_dax_huge_fault,
> .pfn_mkwrite = ext4_dax_pfn_mkwrite,
> };
> #else
> --
> 2.9.0
Hey Arnd,
I saw this as well, but fixed it by removing ext4_dax_huge_fault() since after
Dave's changes ext4_dax_fault() and ext4_dax_huge_fault() are identical.
http://www.spinics.net/lists/linux-mm/msg121117.html
If you're alright with it let's go that way so we can remove a redundant
function.
- Ross
prev parent reply other threads:[~2017-02-02 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 11:36 [PATCH] ext4: fix up huge_fault rename Arnd Bergmann
2017-02-02 20:02 ` Ross Zwisler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202200220.GA14747@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave.jiang@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=mszeredi@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).