From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
Calvin Owens <calvinowens@fb.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
Peter Hurley <peter@hurleysoftware.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts
Date: Fri, 3 Feb 2017 10:57:57 +0900 [thread overview]
Message-ID: <20170203015757.GB6228@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170202093409.3d7f617e@gandalf.local.home>
On (02/02/17 09:34), Steven Rostedt wrote:
> On Thu, 2 Feb 2017 11:02:57 +0900
> Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:
>
> > On (02/01/17 11:37), Steven Rostedt wrote:
> > > This looks fine, but I'm curious if you tested it. That is, added a
> > > bunch of printks to overflow the buffer. IIRC, I did it to the original
> > > nmi code. If you haven't you may want to just to make sure it works. I
> > > can also test it too if I get some time.
> >
> > Hello Steven,
> >
> > yes, I have tested it on my x86 box.
> >
>
> Please note how you tested it in your change log. It's not really a
> requirement, and you don't really have to do it. But it helps people
> have warm fuzzies about the code. I'm trying to do this in the future
> in my own work too.
well. sure, no objections, but in this particular case it's hardly possible
to hit all of those problems within a reasonable time. so what I did was just
a bunch of dirty hacks to provoke the problems. something like this
extern int XXX;
vprintk_emit()
{
spin_lock(&logbuf_lock);
//
// in various places
//
if (XXX == 1) {
WARN_ON(1);
}
spin_unlock(&logbuf_lock);
}
and I set/clear that XXX from one of sysfs attrs... yeah, I know...
but it does what I want. so I'm not really sure I want to note this
in the change log. am I wrong?
-ss
next prev parent reply other threads:[~2017-02-03 1:57 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 14:16 [PATCHv7 0/8] printk: use printk_safe to handle printk() recursive calls Sergey Senozhatsky
2016-12-27 14:16 ` [PATCHv7 1/8] printk: use vprintk_func in vprintk() Sergey Senozhatsky
2016-12-27 14:16 ` [PATCHv7 2/8] printk: rename nmi.c and exported api Sergey Senozhatsky
2017-01-04 13:07 ` Petr Mladek
2017-02-01 15:48 ` Steven Rostedt
2017-02-01 15:50 ` Steven Rostedt
2017-02-23 7:50 ` Geert Uytterhoeven
2017-02-23 8:02 ` Sergey Senozhatsky
2017-02-23 9:23 ` Geert Uytterhoeven
2016-12-27 14:16 ` [PATCHv7 3/8] printk: introduce per-cpu safe_print seq buffer Sergey Senozhatsky
2017-01-04 13:31 ` Petr Mladek
2017-01-05 1:01 ` Sergey Senozhatsky
2017-02-01 15:52 ` Steven Rostedt
2016-12-27 14:16 ` [PATCHv7 4/8] printk: always use deferred printk when flush printk_safe lines Sergey Senozhatsky
2017-02-01 16:06 ` Steven Rostedt
2017-02-02 6:05 ` Sergey Senozhatsky
2017-02-02 15:37 ` Petr Mladek
2017-02-02 15:52 ` Petr Mladek
2017-02-03 2:04 ` Sergey Senozhatsky
2017-02-03 11:18 ` Petr Mladek
2017-02-06 1:48 ` Sergey Senozhatsky
2017-02-06 2:08 ` Sergey Senozhatsky
2017-02-06 12:16 ` Petr Mladek
2017-02-06 13:27 ` Steven Rostedt
2017-02-06 16:42 ` Sergey Senozhatsky
2017-02-06 16:55 ` Steven Rostedt
2016-12-27 14:16 ` [PATCHv7 5/8] printk: report lost messages in printk safe/nmi contexts Sergey Senozhatsky
2017-01-04 14:46 ` Petr Mladek
2017-01-05 1:01 ` Sergey Senozhatsky
2017-02-01 16:37 ` Steven Rostedt
2017-02-02 2:02 ` Sergey Senozhatsky
2017-02-02 14:34 ` Steven Rostedt
2017-02-02 16:13 ` Petr Mladek
2017-02-03 1:57 ` Sergey Senozhatsky [this message]
2017-02-03 3:13 ` Steven Rostedt
2016-12-27 14:16 ` [PATCHv7 6/8] printk: use printk_safe buffers in printk Sergey Senozhatsky
2017-01-31 17:27 ` Ross Zwisler
2017-02-01 9:06 ` Jan Kara
2017-02-01 9:37 ` Peter Zijlstra
2017-02-01 15:39 ` Petr Mladek
2017-02-01 16:15 ` Peter Zijlstra
2017-02-01 16:41 ` Steven Rostedt
2017-02-02 2:11 ` Sergey Senozhatsky
2017-02-02 9:07 ` Peter Zijlstra
2017-02-02 10:03 ` Sergey Senozhatsky
2017-02-02 15:20 ` Petr Mladek
2017-02-03 2:45 ` Sergey Senozhatsky
2017-02-02 1:59 ` Sergey Senozhatsky
2017-02-01 17:04 ` Steven Rostedt
2017-02-02 2:13 ` Sergey Senozhatsky
2016-12-27 14:16 ` [PATCHv7 7/8] printk: remove zap_locks() function Sergey Senozhatsky
2016-12-27 14:16 ` [PATCHv7 8/8] printk: convert the rest to printk-safe Sergey Senozhatsky
2017-01-04 16:28 ` Petr Mladek
2017-01-05 1:00 ` Sergey Senozhatsky
2017-01-05 16:58 ` [PATCHv7 0/8] printk: use printk_safe to handle printk() recursive calls Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203015757.GB6228@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=calvinowens@fb.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peter@hurleysoftware.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).