From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753086AbdBCJ4M (ORCPT ); Fri, 3 Feb 2017 04:56:12 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:52657 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752875AbdBCJ4K (ORCPT ); Fri, 3 Feb 2017 04:56:10 -0500 Date: Fri, 3 Feb 2017 07:55:55 -0200 From: Mauro Carvalho Chehab To: Tabrez khan Cc: mchehab@kernel.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:bcm2048 : Add parentheses around variable x Message-ID: <20170203075555.3038fb36@vento.lan> In-Reply-To: <1480758266-6160-1-git-send-email-khan.tabrez21@gmail.com> References: <1480758266-6160-1-git-send-email-khan.tabrez21@gmail.com> Organization: Samsung X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, 3 Dec 2016 15:14:26 +0530 Tabrez khan escreveu: > Add parentheses around variable x for the readability purpose. > > This warning was found using checkpatch.pl. > > Signed-off-by: Tabrez khan > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c > index 4d9bd02..2f28dd0 100644 > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c > @@ -185,7 +185,7 @@ > #define v4l2_to_dev(f) ((f * BCM2048_FREQV4L2_MULTI) / BCM2048_FREQDEV_UNIT) > > #define msb(x) ((u8)((u16)x >> 8)) > -#define lsb(x) ((u8)((u16)x & 0x00FF)) > +#define lsb(x) ((u8)((u16)(x) & 0x00FF)) If you're willing to do that, you should do on all macros. Also, plese remove the extra space before the hexa value. > #define compose_u16(msb, lsb) (((u16)msb << 8) | lsb) > > #define BCM2048_DEFAULT_POWERING_DELAY 20 Thanks, Mauro