From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752646AbdBCO55 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Feb 2017 09:57:57 -0500
Received: from mail.kernel.org ([198.145.29.136]:34606 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751638AbdBCO5z (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Feb 2017 09:57:55 -0500
Date: Fri, 3 Feb 2017 09:57:50 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [for-next][PATCH 4/8] ftrace: Reset fgd->hash in
 ftrace_graph_write()
Message-ID: <20170203095750.3e70e816@gandalf.local.home>
In-Reply-To: <CAM9d7cg+HLSwZpmq=s+Dc9zZHZd0bCZBQstR80L08X+OJpdckg@mail.gmail.com>
References: <20170203134033.087760237@goodmis.org>
        <20170203134137.170783029@goodmis.org>
        <CAM9d7cg+HLSwZpmq=s+Dc9zZHZd0bCZBQstR80L08X+OJpdckg@mail.gmail.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 3 Feb 2017 23:49:38 +0900
Namhyung Kim <namhyung@kernel.org> wrote:

> On Fri, Feb 3, 2017 at 10:40 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >
> > fgd->hash is saved and then freed, but is never reset to either
> > ftrace_graph_hash nor ftrace_graph_notrace_hash. But if multiple reads are
> > performed, then the freed hash could be accessed again.  
> 
> Argh, right.  Btw did you mean multiple "write" not "read", no?
> 

Argh, right! or "write" I mean.

;-)

-- Steve