From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Nayna <nayna@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
open list <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm: fix type issues in tpm_getcap()
Date: Fri, 3 Feb 2017 20:15:23 +0200 [thread overview]
Message-ID: <20170203181523.mu4hqhb7epqmthfd@intel.com> (raw)
In-Reply-To: <58947D8E.20000@linux.vnet.ibm.com>
On Fri, Feb 03, 2017 at 06:24:38PM +0530, Nayna wrote:
>
>
> On 02/01/2017 11:23 PM, Jarkko Sakkinen wrote:
> > There are two type issues associated with tpm_getcap().
> >
> > You must not do arithmetic with __be32 or __le32 types because sometimes
> > it results incorrect results. Calculations must be done only with data
> > that is in CPU byte order. This commit migrates tpm_getcap() to struct
> > tpm_buf in order to sort out these issues.
> >
> > The second issue is with struct cap_t as the size of the type bool is
> > assumed to be one byte. This commit sorts out the issue by changing the
> > type to u8.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > ---
> > v2:
> > - Use struct tpm_buf.
> > - Merge the type change of 'owned' to this patch.
> > drivers/char/tpm/tpm-interface.c | 33 ++++++++++++++++++---------------
> > drivers/char/tpm/tpm.h | 15 +--------------
> > 2 files changed, 19 insertions(+), 29 deletions(-)
> >
> > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> > index 423938e..7af1e8c 100644
> > --- a/drivers/char/tpm/tpm-interface.c
> > +++ b/drivers/char/tpm/tpm-interface.c
> > @@ -480,31 +480,34 @@ static const struct tpm_input_header tpm_getcap_header = {
>
> Is tpm_getcap_header still needed ?
Definitely not, thanks. Are you able to try this out so I could
move forward with pull request?
/Jarkko
next prev parent reply other threads:[~2017-02-03 18:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 17:53 [PATCH] tpm: fix type issues in tpm_getcap() Jarkko Sakkinen
2017-02-01 18:18 ` Jarkko Sakkinen
2017-02-01 18:30 ` Jarkko Sakkinen
2017-02-01 18:40 ` Jarkko Sakkinen
2017-02-02 13:50 ` Jarkko Sakkinen
2017-02-03 12:54 ` [tpmdd-devel] " Nayna
2017-02-03 18:15 ` Jarkko Sakkinen [this message]
2017-02-03 18:46 ` Nayna
2017-02-03 19:06 ` Jarkko Sakkinen
2017-02-03 13:48 ` Nayna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203181523.mu4hqhb7epqmthfd@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).