On Fri, Feb 03, 2017 at 01:56:03PM -0800, Dmitry Torokhov wrote: > The code in _regulator_get() got a bit confusing over time, with control > flow jumping to a label from couple of places. Let's untangle it a bit. This is quite hard to review without a concrete description of what the changes actually are... > Signed-off-by: Dmitry Torokhov > --- > drivers/regulator/core.c | 66 +++++++++++++++++++++++++----------------------- > 1 file changed, 34 insertions(+), 32 deletions(-) ...it's a fairly large change in core code which is as you say a little complicated.