From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754038AbdBDKfK (ORCPT ); Sat, 4 Feb 2017 05:35:10 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35138 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753811AbdBDKfJ (ORCPT ); Sat, 4 Feb 2017 05:35:09 -0500 Date: Sat, 4 Feb 2017 11:34:58 +0100 From: Mark Brown To: Dmitry Torokhov Cc: Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20170204103458.vqqhpqhwjwkiizxo@sirena.org.uk> References: <20170203215604.23285-1-dmitry.torokhov@gmail.com> <20170203215604.23285-4-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="scamrxaukqbbjbsg" Content-Disposition: inline In-Reply-To: <20170203215604.23285-4-dmitry.torokhov@gmail.com> X-Cookie: Must be over 21. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:67c:1810:f051:e387:5dab:49ba:da3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/5] regulator: core: simplify _regulator_get() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --scamrxaukqbbjbsg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Feb 03, 2017 at 01:56:03PM -0800, Dmitry Torokhov wrote: > The code in _regulator_get() got a bit confusing over time, with control > flow jumping to a label from couple of places. Let's untangle it a bit. This is quite hard to review without a concrete description of what the changes actually are... > Signed-off-by: Dmitry Torokhov > --- > drivers/regulator/core.c | 66 +++++++++++++++++++++++++----------------------- > 1 file changed, 34 insertions(+), 32 deletions(-) ...it's a fairly large change in core code which is as you say a little complicated. --scamrxaukqbbjbsg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAliVrk8ACgkQJNaLcl1U h9C4mgf+JkXdUo4EbYO6p787mQJG/zWbJGyCg+614Nz7HSijb3bSeNX//sDku7I2 rKzCN6mWrHt+R9jsvjOhjZQRPqdC+iB0ZDwTQW9YO3N5dMVu3bRv3jCS8vp92Vc2 biZDdAxibLjWRmptm7bhnc301ENp+r/ha2H5n92BM9XiIBxaRdaizFqZMBNiJ9Vy X5ZP9H148dIK1A5QgMhAgFC5J1/6aTu2+PWGAxMNxAE2Ytw+wjM1YgSY3XvNWirw 1RhdO+kWMs0A5bAZHqyDLJiaV29sdT511omoD/XWll13qPwrklZyZ8gZJdXFkNoS tREk0PwOIMQ5G+NRgeP8Ll+uq/vHmA== =66VA -----END PGP SIGNATURE----- --scamrxaukqbbjbsg--