From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbdBEKIo (ORCPT ); Sun, 5 Feb 2017 05:08:44 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:32870 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbdBEKIm (ORCPT ); Sun, 5 Feb 2017 05:08:42 -0500 Date: Sun, 5 Feb 2017 11:08:37 +0100 From: Ingo Molnar To: borntraeger@de.ibm.com, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, longman@redhat.com, changbin.du@intel.com, jstancek@redhat.com, akpm@linux-foundation.org Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:core/debugobjects] debugobjects: Track number of kmem_cache_alloc/kmem_cache_free done Message-ID: <20170205100837.GB8377@gmail.com> References: <1483647425-4135-2-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * tip-bot for Waiman Long wrote: > Commit-ID: c4b73aabd0989d93b82894417ae501690bd1db5e > Gitweb: http://git.kernel.org/tip/c4b73aabd0989d93b82894417ae501690bd1db5e > Author: Waiman Long > AuthorDate: Thu, 5 Jan 2017 15:17:03 -0500 > Committer: Thomas Gleixner > CommitDate: Sat, 4 Feb 2017 09:01:54 +0100 > > debugobjects: Track number of kmem_cache_alloc/kmem_cache_free done > > New debugfs stat counters are added to track the numbers of > kmem_cache_alloc() and kmem_cache_free() function calls to get a > sense of how the internal debug objects cache management is performing. > > Signed-off-by: Waiman Long > Cc: Christian Borntraeger > Cc: "Du Changbin" > Cc: Andrew Morton > Cc: Jan Stancek > Link: http://lkml.kernel.org/r/1483647425-4135-2-git-send-email-longman@redhat.com > Signed-off-by: Thomas Gleixner > > --- > lib/debugobjects.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/lib/debugobjects.c b/lib/debugobjects.c > index 04c1ef7..d78673e 100644 > --- a/lib/debugobjects.c > +++ b/lib/debugobjects.c > @@ -55,6 +55,12 @@ static int debug_objects_enabled __read_mostly > > static struct debug_obj_descr *descr_test __read_mostly; > > +/* > + * Track numbers of kmem_cache_alloc and kmem_cache_free done. Nit: /* * Track the number of kmem_cache_alloc()/free() calls done. */ Another nit: > + */ > +static int debug_objects_alloc; > +static int debug_objects_freed; Yeah, so we want to either use past tense consistently: static int debug_objects_allocated; static int debug_objects_freed; Or we want to use present tense consistently: static int debug_objects_alloc; static int debug_objects_free; ... but we don't want to mix the two when naming related counters! ( Btw., I'm for the _allocated/_freed pattern, that's what the usual nomenclature for statistics counters. ) > + seq_printf(m, "objects_alloc :%d\n", debug_objects_alloc); > + seq_printf(m, "objects_freed :%d\n", debug_objects_freed); Ditto. Thanks, Ingo