From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbdBEUgP (ORCPT + 2 others); Sun, 5 Feb 2017 15:36:15 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:28635 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdBEUgO (ORCPT ); Sun, 5 Feb 2017 15:36:14 -0500 Date: Sun, 5 Feb 2017 21:35:19 +0100 From: Willy Tarreau To: Joe Perches Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net, Andrew Morton , Linus Torvalds Subject: Re: [PATCH 3.10 275/319] ipc: remove use of seq_printf return value Message-ID: <20170205203519.GA8835@1wt.eu> References: <1486322541-8206-1-git-send-email-w@1wt.eu> <1486322541-8206-176-git-send-email-w@1wt.eu> <1486324173.22276.93.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486324173.22276.93.camel@perches.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Joe, On Sun, Feb 05, 2017 at 11:49:33AM -0800, Joe Perches wrote: > On Sun, 2017-02-05 at 20:21 +0100, Willy Tarreau wrote: > > From: Joe Perches > > > > commit 7f032d6ef6154868a2a5d5f6b2c3f8587292196c upstream. > > > > The seq_printf return value, because it's frequently misused, > > will eventually be converted to void. > > Is this necessary? It doesn't seem so. > > This one seems an unlikely candidate to backport as > it effectively doesn't do anything but prepare for > seq_printf return value removal. > > Is that removal going to be backported too or is this > being patched to avoid some other backported patch's > desire to be applied without offsets? Hmmm sorry, I missed the comment on this one, it was picked because it makes it easier to apply "ipc/sem.c: fix complex_count vs. simple op race". This latter was picked as-is from Jiri's 3.12 tree so I preferred to avoid modifying it. I'll just mention it in the commit message. Thanks for notifying me. Willy