From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752770AbdBFCIF (ORCPT <rfc822;w@1wt.eu>);
        Sun, 5 Feb 2017 21:08:05 -0500
Received: from mail-pg0-f68.google.com ([74.125.83.68]:33213 "EHLO
        mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752277AbdBFCIE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 5 Feb 2017 21:08:04 -0500
Date: Mon, 6 Feb 2017 11:08:20 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
        Calvin Owens <calvinowens@fb.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Hurley <peter@hurleysoftware.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7 4/8] printk: always use deferred printk when flush
 printk_safe lines
Message-ID: <20170206020820.GB1750@jagdpanzerIV.localdomain>
References: <20161227141611.940-1-sergey.senozhatsky@gmail.com>
 <20161227141611.940-5-sergey.senozhatsky@gmail.com>
 <20170201110648.33651ee8@gandalf.local.home>
 <20170202060538.GA419@jagdpanzerIV.localdomain>
 <20170202153753.GF23754@pathway.suse.cz>
 <20170202155252.GG23754@pathway.suse.cz>
 <20170203020418.GC6228@jagdpanzerIV.localdomain>
 <20170203111849.GO23754@pathway.suse.cz>
 <20170206014846.GA1750@jagdpanzerIV.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170206014846.GA1750@jagdpanzerIV.localdomain>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (02/06/17 10:48), Sergey Senozhatsky wrote:
[..]
> from many places:
> 
>   4x   printk_safe_flush_buffer()
>   1x   __printk_safe_flush()
> 
> 
> replacing printk_safe_flush_line() with printk_deferred() produces things
> like these
> 
>                printk_deferred("%.*s", end - start, start);
>                printk_deferred("%.*s", strlen(newline), newline);

ah... besides we need to cast length argument to "int".


> just in case, the patch (which I prefer to be ignored)

let's keep printk_safe_flush_line().

	-ss