From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752085AbdBFN1q (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Feb 2017 08:27:46 -0500
Received: from mail.kernel.org ([198.145.29.136]:45168 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751473AbdBFN1o (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Feb 2017 08:27:44 -0500
Date: Mon, 6 Feb 2017 08:27:39 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jan Kara <jack@suse.cz>, Tejun Heo <tj@kernel.org>,
        Calvin Owens <calvinowens@fb.com>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Hurley <peter@hurleysoftware.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv7 4/8] printk: always use deferred printk when flush
 printk_safe lines
Message-ID: <20170206082739.18a47c8e@gandalf.local.home>
In-Reply-To: <20170206121652.GA2769@pathway.suse.cz>
References: <20161227141611.940-1-sergey.senozhatsky@gmail.com>
        <20161227141611.940-5-sergey.senozhatsky@gmail.com>
        <20170201110648.33651ee8@gandalf.local.home>
        <20170202060538.GA419@jagdpanzerIV.localdomain>
        <20170202153753.GF23754@pathway.suse.cz>
        <20170202155252.GG23754@pathway.suse.cz>
        <20170203020418.GC6228@jagdpanzerIV.localdomain>
        <20170203111849.GO23754@pathway.suse.cz>
        <20170206014846.GA1750@jagdpanzerIV.localdomain>
        <20170206020820.GB1750@jagdpanzerIV.localdomain>
        <20170206121652.GA2769@pathway.suse.cz>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 6 Feb 2017 13:16:52 +0100
Petr Mladek <pmladek@suse.com> wrote:

 
> > > just in case, the patch (which I prefer to be ignored)  
> > 
> > let's keep printk_safe_flush_line().  
> 
> I do not have strong opinion but I would slightly prefer
> to keep the helper function. The use of printk_deferred()
> is a bit tricky and it is better to have only one copy.
> 
> Steven, could you live with the original patch, please?

Sure, but make it into a static inline.

-- Steve