Re: [PATCHSET 0/3] perf diff: Introduce delta-abs compute method

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Minchan Kim <minchan@kernel.org>,
	Taeung Song <treeze.taeung@gmail.com>
Subject: Re: [PATCHSET 0/3] perf diff: Introduce delta-abs compute method
Date: Mon, 6 Feb 2017 11:14:10 -0300	[thread overview]
Message-ID: <20170206141410.GC11283@kernel.org> (raw)
In-Reply-To: <20170206134403.GB2156@danjae.aot.lge.com>

Em Mon, Feb 06, 2017 at 10:44:03PM +0900, Namhyung Kim escreveu:
> On Mon, Feb 06, 2017 at 11:26:17AM +0100, Jiri Olsa wrote:
> > On Mon, Feb 06, 2017 at 04:20:34PM +0900, Namhyung Kim wrote:
> > > Namhyung Kim (3):
> > >   perf diff: Add 'delta-abs' compute method
> > >   perf diff: Add diff.order config option
> > >   perf diff: Add diff.compute config option

> > hum, do I miss some -o fix?

> > [jolsa@krava perf]$ ./perf diff -o 1 -c delta-abs
> > Segmentation fault (core dumped)

> > it's not delta-abs specific, I'm getting the crash for others

> Yes, the fixes are in perf/urgent and it seems not sync'ed to
> perf/core yet.  If you pull my branch it has the fixes as well.

Just merged tip/perf/urgent into acme/perf/core, just pushed it to
git.kernel.org,

- Arnaldo

> Thanks,
> Namhyung
> 
> 
> > 
> > thanks,
> > jirka
> > 
> > 
> > (gdb) r diff -o 1 -c delta-abs
> > Starting program: /home/jolsa/kernel/linux-perf/tools/perf/perf diff -o 1 -c delta-abs
> > Missing separate debuginfos, use: dnf debuginfo-install glibc-2.23.1-11.fc24.x86_64
> > [Thread debugging using libthread_db enabled]
> > Using host libthread_db library "/lib64/libthread_db.so.1".
> > Detaching after fork from child process 12611.
> > 
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x0000000000000000 in ?? ()
> > Missing separate debuginfos, use: dnf debuginfo-install audit-libs-2.7.1-1.fc24.x86_64 bzip2-libs-1.0.6-21.fc24.x86_64 elfutils-libelf-0.168-1.fc24.x86_64 elfutils-libs-0.168-1.fc24.x86_64 libcap-ng-0.7.8-1.fc24.x86_64 libunwind-1.1-11.fc24.x86_64 nss-softokn-freebl-3.28.1-1.0.fc24.x86_64 numactl-libs-2.0.11-2.fc24.x86_64 openssl-libs-1.0.2j-3.fc24.x86_64 perl-libs-5.22.3-368.fc24.x86_64 python-libs-2.7.13-1.fc24.x86_64 slang-2.3.0-5.fc24.x86_64 xz-libs-5.2.2-2.fc24.x86_64 zlib-1.2.8-10.fc24.x86_64
> > (gdb) bt
> > #0  0x0000000000000000 in ?? ()
> > #1  0x000000000059c3c2 in fprintf_line (hists=0x2159980, hpp=0x7fffffffda60, line=0, fp=0x7ffff55c3600 <_IO_2_1_stdout_>)
> >     at ui/stdio/hist.c:677
> > #2  0x000000000059c4af in hists__fprintf_standard_headers (hists=0x2159980, hpp=0x7fffffffda60, fp=0x7ffff55c3600 <_IO_2_1_stdout_>)
> >     at ui/stdio/hist.c:700
> > #3  0x000000000059c707 in hists__fprintf_headers (hists=0x2159980, fp=0x7ffff55c3600 <_IO_2_1_stdout_>) at ui/stdio/hist.c:745
> > #4  0x000000000059c7b9 in hists__fprintf (hists=0x2159980, show_header=true, max_rows=0, max_cols=0, min_pcnt=0, 
> >     fp=0x7ffff55c3600 <_IO_2_1_stdout_>, use_callchain=false) at ui/stdio/hist.c:769
> > #5  0x000000000042b6aa in hists__process (hists=0x2159980) at builtin-diff.c:694
> > #6  0x000000000042b944 in data_process () at builtin-diff.c:753
> > #7  0x000000000042bb2b in __cmd_diff () at builtin-diff.c:790
> > #8  0x000000000042d0ed in cmd_diff (argc=0, argv=0x7fffffffe3d0, prefix=0x0) at builtin-diff.c:1349
> > #9  0x00000000004b817e in run_builtin (p=0xa10be0 <commands+96>, argc=5, argv=0x7fffffffe3d0) at perf.c:359
> > #10 0x00000000004b83eb in handle_internal_command (argc=5, argv=0x7fffffffe3d0) at perf.c:421
> > #11 0x00000000004b8530 in run_argv (argcp=0x7fffffffe21c, argv=0x7fffffffe210) at perf.c:467
> > #12 0x00000000004b8933 in main (argc=5, argv=0x7fffffffe3d0) at perf.c:614