From: Jisheng Zhang <jszhang@marvell.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <thomas.petazzoni@free-electrons.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Jingju Hou <houjingj@marvell.com>
Subject: Re: [PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol
Date: Mon, 6 Feb 2017 15:08:48 +0800 [thread overview]
Message-ID: <20170206150848.295d97ba@xhacker> (raw)
In-Reply-To: <20170123181034.GN10895@lunn.ch>
Hi Andrew,
On Mon, 23 Jan 2017 19:10:34 +0100 Andrew Lunn wrote:
>
> On Mon, Jan 23, 2017 at 02:55:07PM +0800, Jisheng Zhang wrote:
> > From: Jingju Hou <houjingj@marvell.com>
> >
> > From: Jingju Hou <houjingj@marvell.com>
> >
> > The mvneta itself does not support WOL, but the PHY might.
> > So pass the calls to the PHY
> >
> > Signed-off-by: Jingju Hou <houjingj@marvell.com>
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > ---
> > since v3:
> > - really fix the build error
>
> Keep trying....
>
> But maybe tomorrow, after you have taken the pause Dave said you
> should take, and maybe ask Jingju to really review it, in detail.
Jingju is a newbie in the Linux kernel community. She made a mistake
when trying to send the old patch. I picked up her patch when she went
on vacation, fixed the error and send it out on behalf of her.
>
> >
> > since v2,v1:
> > - using phy_dev member in struct net_device
> > - add commit msg
> >
> > drivers/net/ethernet/marvell/mvneta.c | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> > index 6dcc951af0ff..02611fa1c3b8 100644
> > --- a/drivers/net/ethernet/marvell/mvneta.c
> > +++ b/drivers/net/ethernet/marvell/mvneta.c
> > @@ -3929,6 +3929,25 @@ static int mvneta_ethtool_get_rxfh(struct net_device *dev, u32 *indir, u8 *key,
> > return 0;
> > }
> >
> > +static void mvneta_ethtool_get_wol(struct net_device *dev,
> > + struct ethtool_wolinfo *wol)
> > +{
> > + wol->supported = 0;
> > + wol->wolopts = 0;
> > +
> > + if (dev->phydev)
> > + return phy_ethtool_get_wol(dev->phydev, wol);
>
> This is a void function. And you are returning a value. And
> phy_ethtool_get_wol() is also a void function, so does not actually
> return anything.
Thanks for catching it, fixed in v4, can you please review?
next prev parent reply other threads:[~2017-02-06 7:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 6:55 [PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol Jisheng Zhang
2017-01-23 18:10 ` Andrew Lunn
2017-02-06 7:08 ` Jisheng Zhang [this message]
2017-02-06 7:10 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206150848.295d97ba@xhacker \
--to=jszhang@marvell.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=houjingj@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).