From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751314AbdBFHO7 (ORCPT ); Mon, 6 Feb 2017 02:14:59 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:43731 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdBFHO6 (ORCPT ); Mon, 6 Feb 2017 02:14:58 -0500 Date: Mon, 6 Feb 2017 15:10:32 +0800 From: Jisheng Zhang To: Andrew Lunn CC: , , , , Jingju Hou Subject: Re: [PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol Message-ID: <20170206151032.7cb21fdc@xhacker> In-Reply-To: <20170206150848.295d97ba@xhacker> References: <20170123065507.2557-1-jszhang@marvell.com> <20170123181034.GN10895@lunn.ch> <20170206150848.295d97ba@xhacker> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-06_02:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702060073 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Feb 2017 15:08:48 +0800 Jisheng Zhang wrote: > Hi Andrew, > > On Mon, 23 Jan 2017 19:10:34 +0100 Andrew Lunn wrote: > > > > > On Mon, Jan 23, 2017 at 02:55:07PM +0800, Jisheng Zhang wrote: > > > From: Jingju Hou > > > > > > From: Jingju Hou > > > > > > The mvneta itself does not support WOL, but the PHY might. > > > So pass the calls to the PHY > > > > > > Signed-off-by: Jingju Hou > > > Signed-off-by: Jisheng Zhang > > > --- > > > since v3: > > > - really fix the build error > > > > Keep trying.... > > > > But maybe tomorrow, after you have taken the pause Dave said you > > should take, and maybe ask Jingju to really review it, in detail. > > Jingju is a newbie in the Linux kernel community. She made a mistake > when trying to send the old patch. I picked up her patch when she went > on vacation, fixed the error and send it out on behalf of her. > > > > > > > > > since v2,v1: > > > - using phy_dev member in struct net_device > > > - add commit msg > > > > > > drivers/net/ethernet/marvell/mvneta.c | 21 +++++++++++++++++++++ > > > 1 file changed, 21 insertions(+) > > > > > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > > > index 6dcc951af0ff..02611fa1c3b8 100644 > > > --- a/drivers/net/ethernet/marvell/mvneta.c > > > +++ b/drivers/net/ethernet/marvell/mvneta.c > > > @@ -3929,6 +3929,25 @@ static int mvneta_ethtool_get_rxfh(struct net_device *dev, u32 *indir, u8 *key, > > > return 0; > > > } > > > > > > +static void mvneta_ethtool_get_wol(struct net_device *dev, > > > + struct ethtool_wolinfo *wol) > > > +{ > > > + wol->supported = 0; > > > + wol->wolopts = 0; > > > + > > > + if (dev->phydev) > > > + return phy_ethtool_get_wol(dev->phydev, wol); > > > > This is a void function. And you are returning a value. And > > phy_ethtool_get_wol() is also a void function, so does not actually > > return anything. > > Thanks for catching it, fixed in v4, can you please review? typo, fixed in v5.