From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbdBGA5D (ORCPT ); Mon, 6 Feb 2017 19:57:03 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35773 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbdBGA47 (ORCPT ); Mon, 6 Feb 2017 19:56:59 -0500 Date: Mon, 6 Feb 2017 16:56:55 -0800 From: Dmitry Torokhov To: Mark Brown Cc: Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] regulator: core: lower severity level of message about using dummy supplies Message-ID: <20170207005655.GB35854@dtor-ws> References: <20170203215604.23285-1-dmitry.torokhov@gmail.com> <20170203215604.23285-5-dmitry.torokhov@gmail.com> <20170204114819.xa3goicde4gadvrd@sirena.org.uk> <20170204174502.GA12980@dtor-ws> <20170205161246.mqn5wfxo2krtwps6@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170205161246.mqn5wfxo2krtwps6@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 05, 2017 at 05:12:46PM +0100, Mark Brown wrote: > On Sat, Feb 04, 2017 at 09:45:02AM -0800, Dmitry Torokhov wrote: > > On Sat, Feb 04, 2017 at 12:48:19PM +0100, Mark Brown wrote: > > > > It really shouldn't be either of these things, at least on DT systems. > > > But it definitely happens on ACPI systems for drivers for peripherals > > that we share between both x86 and ARM. > > Something that makes the warning informational only on ACPI systems > would be fine. I can definitely select the severity based on acpi_disabled flag, but I think you should reconsider: from what I have seen in the kernel quite a few driversi, even OF-specific ones, select regulator_get_optional() for no good reason other than to avoid this "scary" warning. If its severity were reduced quite a few drivers could be switched to normal regulator_get(). Candidates for conversion (not complete, just examples): drivers/input/touchscreen/zforce_ts.c drivers/input/touchscreen/tsc200x-core.c drivers/power/avs/rockchip-io-domain.c drivers/mfd/stmpe.c ... and more... Thanks. -- Dmitry