From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752627AbdBGBFx (ORCPT ); Mon, 6 Feb 2017 20:05:53 -0500 Received: from mail.kernel.org ([198.145.29.136]:37406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbdBGBFv (ORCPT ); Mon, 6 Feb 2017 20:05:51 -0500 Date: Tue, 7 Feb 2017 10:05:41 +0900 From: Masami Hiramatsu To: "Naveen N. Rao" Cc: Michael Ellerman , Anju T Sudhakar , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ananth@in.ibm.com, mahesh@linux.vnet.ibm.com, paulus@samba.org, mhiramat@kernel.org, srikar@linux.vnet.ibm.com Subject: Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes Message-Id: <20170207100541.7860e846f3def13a628bb05d@kernel.org> In-Reply-To: <20170203193949.GD4090@naverao1-tp.localdomain> References: <1482153507-17350-1-git-send-email-anju@linux.vnet.ibm.com> <1482153507-17350-2-git-send-email-anju@linux.vnet.ibm.com> <87a8a6dvwo.fsf@concordia.ellerman.id.au> <20170203193949.GD4090@naverao1-tp.localdomain> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Feb 2017 01:09:49 +0530 "Naveen N. Rao" wrote: > Hi Michael, > Thanks for the review! I'll defer to Anju on most of the aspects, but... > > On 2017/02/01 09:53PM, Michael Ellerman wrote: > > Anju T Sudhakar writes: > > > > > +static void optimized_callback(struct optimized_kprobe *op, > > > + struct pt_regs *regs) > > > +{ > > > + struct kprobe_ctlblk *kcb = get_kprobe_ctlblk(); > > > + unsigned long flags; > > > + > > > + /* This is possible if op is under delayed unoptimizing */ > > > + if (kprobe_disabled(&op->kp)) > > > + return; > > > + > > > + local_irq_save(flags); > > > > What is that protecting against? Because on powerpc it doesn't actually > > disable interrupts, it just masks some of them, the perf interrupt for > > example can still run. > > That's an excellent catch, as always! :) > > This is meant to prevent us from missing kprobe hits while processing > interrupts that arrive when this optprobe is being handled. And you are > totally right -- we would miss kprobe hits during PMI handling with the > current approach. We need a hard_irq_disable() there. One note: it depends on the arch implementation of kprobes, since this is only for "emulating" the int3 behavior on x86 for compatibility. On x86, int3 is disabling interrupt automatically, so all the kprobes user handlers will be run under irq-disabled. This means that user may write their code to run as such condition. They even can not know that is optimized or not at programming timing, because the kprobe will be optimized after a while from enabled it. So the important point is that you have to keep it compatible of unoptimized kprobes. Thank you, -- Masami Hiramatsu