From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Dave Airlie <airlied@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v3 2/7] drm/tinydrm: Add helper functions
Date: Tue, 7 Feb 2017 12:21:28 +0100 [thread overview]
Message-ID: <20170207112128.gzgxmry3ttkcud7y@phenom.ffwll.local> (raw)
In-Reply-To: <20170207111128.GE29507@ulmo.ba.sec>
On Tue, Feb 07, 2017 at 12:11:28PM +0100, Thierry Reding wrote:
> On Tue, Feb 07, 2017 at 08:28:16AM +1000, Dave Airlie wrote:
> > >
> > > I definitely don't want that we don't attempt this. But brought from years
> > > of experience, I recommend to merge first (with pre-refactoring already
> > > applied, but helpers only extracted, not yet at the right spot), and then
> > > follow up with. Because on average, there's way too many trees with
> > > overloaded maintainers who maybe look at your patch once per kernel
> > > release cycle.
> > >
> > > If you know that backlight and spi isn't one of these areas (anything that
> > > goes through takashi/sound is a similar good experience for us on the i915
> > > side), then I guess we can try. But then Noralf has already written a few
> > > months worth of really great refactoring, and I'm seriously starting to
> > > feel guilty for volunteering him for all of this. Even though he seems to
> > > be really good at it, and seems to not mind, it's getting a bit silly.
> > > Given that I'd say up to Noralf.
> > >
> > > In short, there's always a balance.
> >
> > I don't think we can make a rule for this, it will always depend on the
> > code. There is always going to be stuff we put in drm that should go
> > elsewhere, and stuff that is elsewhere that drm should use.
> >
> > I think however if we do add stuff like this, someone should keep track
> > of them and try to make them get further into the kernel.
>
> Yes, I think having some sort of TODO in drivers/gpu/drm could help
> track things that we know should eventually be moved out. It could serve
> as a list of janitorial tasks for newcomers that want to get their hands
> dirty and tackle relatively trivial tasks.
We have this list already, it's at: http://www.x.org/wiki/DRMJanitors/
I guess I should highlight it more, maybe even add it to the docs? Eric
just asked about it last week too.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-02-07 11:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 16:03 [PATCH v3 0/7] drm: Add support for tiny LCD displays Noralf Trønnes
2017-01-31 16:03 ` [PATCH v3 1/7] drm: Add DRM " Noralf Trønnes
2017-01-31 16:23 ` Daniel Vetter
2017-01-31 18:01 ` Noralf Trønnes
2017-01-31 20:10 ` Daniel Vetter
2017-02-06 9:17 ` Thierry Reding
2017-02-06 19:23 ` Noralf Trønnes
2017-02-07 6:58 ` Daniel Vetter
2017-02-07 11:48 ` Thierry Reding
2017-02-06 10:12 ` Jani Nikula
2017-01-31 16:03 ` [PATCH v3 2/7] drm/tinydrm: Add helper functions Noralf Trønnes
2017-02-06 8:56 ` Thierry Reding
2017-02-06 9:09 ` Daniel Vetter
2017-02-06 9:35 ` Thierry Reding
[not found] ` <CAKMK7uHgW15EPpPSU2se7r89JCGD_oTvn9ZJptYaNJAWMKb9Fg@mail.gmail.com>
2017-02-06 11:08 ` Thierry Reding
2017-02-06 15:53 ` Daniel Vetter
2017-02-06 22:11 ` Noralf Trønnes
2017-02-07 11:38 ` Thierry Reding
2017-02-06 22:28 ` Dave Airlie
2017-02-07 7:00 ` Daniel Vetter
2017-02-07 11:11 ` Thierry Reding
2017-02-07 11:21 ` Daniel Vetter [this message]
2017-02-07 11:44 ` Thierry Reding
2017-02-07 13:23 ` Daniel Vetter
2017-02-06 22:55 ` Rob Herring
2017-02-07 7:08 ` Daniel Vetter
2017-02-06 10:10 ` Jani Nikula
2017-01-31 16:03 ` [PATCH v3 3/7] drm/tinydrm: Add MIPI DBI support Noralf Trønnes
2017-02-06 8:48 ` Thierry Reding
2017-02-06 11:30 ` Jani Nikula
2017-02-06 11:53 ` Thierry Reding
2017-02-06 12:34 ` Andrzej Hajda
2017-02-06 15:45 ` Noralf Trønnes
2017-02-06 11:25 ` Jani Nikula
2017-01-31 16:03 ` [PATCH v3 4/7] of: Add vendor prefix for Multi-Inno Noralf Trønnes
2017-01-31 16:03 ` [PATCH v3 5/7] dt-bindings: display: Add common rotation property Noralf Trønnes
2017-02-01 17:41 ` Rob Herring
2017-02-03 12:16 ` Noralf Trønnes
2017-02-06 7:10 ` Thierry Reding
2017-01-31 16:03 ` [PATCH v3 6/7] dt-bindings: Add Multi-Inno MI0283QT binding Noralf Trønnes
2017-02-01 17:42 ` Rob Herring
2017-01-31 16:03 ` [PATCH v3 7/7] drm/tinydrm: Add support for Multi-Inno MI0283QT display Noralf Trønnes
2017-02-06 8:25 ` Thierry Reding
2017-02-07 12:00 ` [PATCH v3 0/7] drm: Add support for tiny LCD displays Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207112128.gzgxmry3ttkcud7y@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).