linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Julien Desfossez <jdesfossez@efficios.com>
Cc: rostedt@goodmis.org, tglx@linutronix.de, mingo@redhat.com,
	bristot@redhat.com, mathieu.desnoyers@efficios.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 2/2] tracing: add policy-based sched_switch events
Date: Tue, 7 Feb 2017 13:23:56 +0100	[thread overview]
Message-ID: <20170207122356.GQ6515@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1484327993-5036-3-git-send-email-jdesfossez@efficios.com>

On Fri, Jan 13, 2017 at 12:19:53PM -0500, Julien Desfossez wrote:
> Add 3 new tracepoints: sched_switch_fair, sched_switch_rt and
> sched_switch_dl.

Do they really _have_ to be whole new tracepoints? I really don't like
littering the user interface with all that.

Furthermore, it doesn't seem to make sense to enable these individually,
either all or none.

> These conditional tracepoints are emitted based on the scheduling class
> of the next task. Each of these tracepoint gets rid of the prio field
> from the original sched_switch and replaces it with fields that are
> relevant to the policy of the next task:
>   - for a fair task: the nice value,
>   - for a rt task: the nice and rt_priority values,

Nice is not relevant to RT.

>   - for a dl task: the runtime, deadline and period values.
> 
> The original sched_switch event is left unmodified, so these new events
> can be enabled at the same time (but they are emitted consecutively so
> we can see a timestamp offset).

So ideally there would only be _1_ sched_switch event that I can enable,
and it would (per default) not print the old style at all.

Some (global?) compat knob could be used to switch back to the old style
output with clear notification that that is going to go away 'soon'.

      reply	other threads:[~2017-02-07 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 17:19 [RFC PATCH v3 0/2] Extend scheduling tracepoints Julien Desfossez
2017-01-13 17:19 ` [RFC PATCH v3 1/2] tracing: add TRACE_EVENT_MAP_COND Julien Desfossez
2017-01-13 17:19 ` [RFC PATCH v3 2/2] tracing: add policy-based sched_switch events Julien Desfossez
2017-02-07 12:23   ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170207122356.GQ6515@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bristot@redhat.com \
    --cc=jdesfossez@efficios.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).