From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add bindings for the Sitronix ST7789V panel
Date: Tue, 7 Feb 2017 16:44:42 +0100 [thread overview]
Message-ID: <20170207154442.dntmddoft3zacxis@lukather> (raw)
In-Reply-To: <20170206130549.GA28955@ulmo.ba.sec>
[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]
Hi Thierry,
On Mon, Feb 06, 2017 at 02:05:49PM +0100, Thierry Reding wrote:
> On Fri, Feb 03, 2017 at 10:59:05AM +0100, Maxime Ripard wrote:
> > The Sitronix ST7789V is an LCD panel controller, controlled over SPI, that
> > can drive 18-bits 240x320 LCD displays.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> > Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt | 36 ++++++++++++++++++++++++++++++++++++
> > 1 file changed, 36 insertions(+), 0 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt
> > new file mode 100644
> > index 000000000000..f70e6e9c54ed
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt
> > @@ -0,0 +1,36 @@
> > +Sitronix ST7789V RGB panel with SPI control bus
> > +
> > +Required properties:
> > + - compatible: "sitronix,st7789v"
> > + - reg: Chip select of the panel on the SPI bus
> > + - reset-gpios: a GPIO phandle for the reset pin
>
> Shouldn't this have some sort of power supply?
On the board I currently have, it's just tied to an always on
regulator, but you're right, I'll add it.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-02-07 15:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:59 [PATCH 0/2] drm/panel: Add support for the Sitronix ST7789V Maxime Ripard
2017-02-03 9:59 ` [PATCH 1/2] dt-bindings: display: panel: Add bindings for the Sitronix ST7789V panel Maxime Ripard
2017-02-06 13:05 ` Thierry Reding
2017-02-07 15:44 ` Maxime Ripard [this message]
2017-02-07 16:42 ` Thierry Reding
2017-02-03 9:59 ` [PATCH 2/2] drm/panel: Add driver for sitronix " Maxime Ripard
2017-02-03 18:53 ` Noralf Trønnes
2017-02-06 10:50 ` Maxime Ripard
2017-02-06 12:13 ` Noralf Trønnes
2017-02-06 12:25 ` Thierry Reding
2017-02-06 13:26 ` Thierry Reding
2017-02-07 15:53 ` Maxime Ripard
2017-02-03 9:59 ` [PATCH v3 1/2] dt-bindings: gpu: Add Mali Utgard bindings Maxime Ripard
2017-02-03 9:59 ` [PATCH v3 2/2] ARM: sun8i: dt: Add mali node Maxime Ripard
2017-02-03 18:48 ` [PATCH 0/2] drm/panel: Add support for the Sitronix ST7789V Noralf Trønnes
2017-02-06 10:39 ` Maxime Ripard
2017-02-06 11:29 ` Noralf Trønnes
2017-02-07 15:34 ` Maxime Ripard
2017-02-07 16:46 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207154442.dntmddoft3zacxis@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).