From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754931AbdBGPuL (ORCPT ); Tue, 7 Feb 2017 10:50:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57406 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754767AbdBGPuJ (ORCPT ); Tue, 7 Feb 2017 10:50:09 -0500 Date: Tue, 7 Feb 2017 13:50:05 -0200 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Ravi Bangoria , linux-kernel@vger.kernel.org, mingo@redhat.com, alexis.berlemont@gmail.com, peterz@infradead.org, alexander.shishkin@linux.intel.com, mpe@ellerman.id.au, naveen.n.rao@linux.vnet.ibm.com, mhiramat@kernel.org, maddy@linux.vnet.ibm.com Subject: Re: [PATCH v2] perf/sdt: Show proper hint Message-ID: <20170207155005.GC4222@redhat.com> References: <20170202162051.GA2266@redhat.com> <20170203102642.17258-1-ravi.bangoria@linux.vnet.ibm.com> <20170203151826.GA2712@redhat.com> <20170207075356.GA21028@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170207075356.GA21028@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 07 Feb 2017 15:50:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Feb 07, 2017 at 08:53:56AM +0100, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo wrote: > > > Em Fri, Feb 03, 2017 at 03:56:42PM +0530, Ravi Bangoria escreveu: > > > After patch: > > > $ perf record -a -e sdt_glib:idle__add > > > event syntax error: 'sdt_glib:idle__add' > > > \___ unknown tracepoint > > > > > > Error: File /sys/kernel/debug/tracing/events/sdt_glib/idle__add not found. > > > Hint: SDT event cannot be directly recorded on. Please use 'perf probe sdt_glib:idle__add' before recording it. > > > ... > > > > > > $ perf probe sdt_glib:idle__add > > > Added new event: > > > sdt_glib:idle__add (on %idle__add in /usr/lib64/libglib-2.0.so.0.5000.2) > > > > > > You can now use it in all perf tools, such as: > > > > > > perf record -e sdt_glib:idle__add -aR sleep 1 > > > > > > $ perf record -a -e sdt_glib:idle__add > > > [ perf record: Woken up 1 times to write data ] > > > [ perf record: Captured and wrote 0.175 MB perf.data ] > > > > Looks much better! Thanks! > > > > Unsure if we should state somewhere that this needs to be done only once > > per boot. > > > > Ingo, are you ok now? Ack? > > Yeah, looks perfect to me! > > Acked-by: Ingo Molnar Thanks, added that "first" and split the Hint line in two. Automagically setting it up, doing the perf probe and rendering the above comment irrelevant remains as a task to be performed. - Arnaldo