From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933046AbdBHJ1i (ORCPT ); Wed, 8 Feb 2017 04:27:38 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38389 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932943AbdBHJ0L (ORCPT ); Wed, 8 Feb 2017 04:26:11 -0500 Date: Wed, 8 Feb 2017 09:26:07 +0000 From: Lee Jones To: Quentin Schulz Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, sre@kernel.org, linux@armlinux.org.uk, maxime.ripard@free-electrons.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@free-electrons.com, icenowy@aosc.xyz, bonbons@linux-vserver.org Subject: Re: [PATCH v2 02/25] mfd: axp20x: correct name of temperature data ADC registers Message-ID: <20170208092607.qlzm7pt4w3wqempf@dell> References: <20170127085458.18270-1-quentin.schulz@free-electrons.com> <20170127085458.18270-3-quentin.schulz@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170127085458.18270-3-quentin.schulz@free-electrons.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Jan 2017, Quentin Schulz wrote: > The registers 0x56 and 0x57 of AXP22X PMIC store the value of the > internal temperature of the PMIC. > > This patch modifies the name of these registers from AXP22X_PMIC_ADC_H/L > to AXP22X_PMIC_TEMP_H/L so their purpose is clearer. > > Signed-off-by: Quentin Schulz > --- > > added in v2 > > drivers/mfd/axp20x.c | 2 +- > include/linux/mfd/axp20x.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 619a83e..9c2fd37 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -102,7 +102,7 @@ static const struct regmap_range axp22x_volatile_ranges[] = { > regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT), > regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IRQ5_STATE), > regmap_reg_range(AXP22X_GPIO_STATE, AXP22X_GPIO_STATE), > - regmap_reg_range(AXP22X_PMIC_ADC_H, AXP20X_IPSOUT_V_HIGH_L), > + regmap_reg_range(AXP22X_PMIC_TEMP_H, AXP20X_IPSOUT_V_HIGH_L), > regmap_reg_range(AXP20X_FG_RES, AXP20X_FG_RES), > }; > > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h > index a4860bc..5ecadbb 100644 > --- a/include/linux/mfd/axp20x.h > +++ b/include/linux/mfd/axp20x.h > @@ -228,8 +228,8 @@ enum { > #define AXP20X_OCV_MAX 0xf > > /* AXP22X specific registers */ > -#define AXP22X_PMIC_ADC_H 0x56 > -#define AXP22X_PMIC_ADC_L 0x57 > +#define AXP22X_PMIC_TEMP_H 0x56 > +#define AXP22X_PMIC_TEMP_L 0x57 > #define AXP22X_TS_ADC_H 0x58 > #define AXP22X_TS_ADC_L 0x59 > #define AXP22X_BATLOW_THRES1 0xe6 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog