From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932954AbdBHJIR (ORCPT ); Wed, 8 Feb 2017 04:08:17 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:38977 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752899AbdBHJHc (ORCPT ); Wed, 8 Feb 2017 04:07:32 -0500 Date: Wed, 8 Feb 2017 10:05:03 +0100 From: Boris Brezillon To: Lee Jones Cc: Stephen Rothwell , Linus Walleij , Greg KH , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Stein , Andy Shevchenko Subject: Re: linux-next: build failure after merge of the gpio tree Message-ID: <20170208100503.375ab31a@bbrezillon> In-Reply-To: <20170208084854.qrxnbrtdnbxefwpg@dell> References: <20170208161113.1b597c01@canb.auug.org.au> <20170208084854.qrxnbrtdnbxefwpg@dell> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Feb 2017 08:48:54 +0000 Lee Jones wrote: > On Wed, 08 Feb 2017, Stephen Rothwell wrote: > > > Hi Linus, > > I believe this patch would need to go in via Greg's tree. > > (see below) > > > After merging the gpio tree, today's linux-next build (arm > > multi_v7_defconfig) failed like this: > > > > drivers/tty/serial/st-asc.c: In function 'asc_set_termios': > > drivers/tty/serial/st-asc.c:578:12: error: implicit declaration of function 'devm_get_gpiod_from_child' [-Werror=implicit-function-declaration] > > gpiod = devm_get_gpiod_from_child(port->dev, "rts", > > ^ > > drivers/tty/serial/st-asc.c:578:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion] > > gpiod = devm_get_gpiod_from_child(port->dev, "rts", > > ^ > > > > Caused by commits > > > > a264d10ff45c ("gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO") > > b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request") > > 4b0947974e59 ("gpio: Rename devm_get_gpiod_from_child()") > > > > interacting with commit > > > > d7356256488c ("serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles") > > > > from the tty tree. > > > > I applied the following merge fix patch (I guessed about the new arguments): > > > > From: Stephen Rothwell > > Date: Wed, 8 Feb 2017 15:50:22 +1100 > > Subject: [PATCH] serial: st-asc: merge fix for devm_get_gpiod_from_child rename > > > > Signed-off-by: Stephen Rothwell > > --- > > drivers/tty/serial/st-asc.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c > > index bcf1d33e6ffe..c02e6b089364 100644 > > --- a/drivers/tty/serial/st-asc.c > > +++ b/drivers/tty/serial/st-asc.c > > @@ -575,8 +575,11 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios, > > pinctrl_select_state(ascport->pinctrl, > > ascport->states[NO_HW_FLOWCTRL]); > > > > - gpiod = devm_get_gpiod_from_child(port->dev, "rts", > > - &np->fwnode); > > + gpiod = devm_fwnode_get_gpiod_from_child(port->dev, > > + "rts", > > + &np->fwnode, > > + GPIOD_IN, > > GPIOD_OUT I think it should be GPIOD_OUT_LOW ... > > > + np->name); > > if (!IS_ERR(gpiod)) { > > gpiod_direction_output(gpiod, 0); ... and you should drop this call to gpiod_direction_output(). > > ascport->rts = gpiod; >